Message-ID: <5547C5BF.2030703@fb.com>
Date: Mon, 4 May 2015 13:17:19 -0600
From: Jens Axboe <axboe@fb.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Shaohua Li <shli@fb.com>, <linux-kernel@vger.kernel.org>
CC: <Kernel-team@fb.com>
Subject: Re: [PATCH] blk-mq: don't lose requests if a stopped queue restarts
References: <430595847fe98f99e1c8ea79b018003d9315f905.1430613052.git.shli@fb.com>
In-Reply-To: <430595847fe98f99e1c8ea79b018003d9315f905.1430613052.git.shli@fb.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1269
Lines: 34

On 05/02/2015 06:31 PM, Shaohua Li wrote:
> Normally if driver is busy to dispatch a request the logic is like below:
> block layer:					driver:
> 	__blk_mq_run_hw_queue
> a.						blk_mq_stop_hw_queue
> b.	rq add to ctx->dispatch
>
> later:
> 1.						blk_mq_start_hw_queue
> 2.	__blk_mq_run_hw_queue
>
> But it's possible step 1-2 runs between a and b. And since rq isn't in
> ctx->dispatch yet, step 2 will not run rq. The rq might get lost if
> there are no subsequent requests kick in.

Good catch! But the patch introduces a potentially never ending loop in 
__blk_mq_run_hw_queue(). Not sure how we can fully close it, but it 
might be better to punt the re-run after adding the requests back to the 
worker. That would turn a potential busy loop (until requests complete) 
into something with nicer behavior, at least. Ala

if (!test_bit(BLK_MQ_S_STOPPED, &hctx->state))
      kblockd_schedule_delayed_work_on(blk_mq_hctx_next_cpu(hctx),
                                         &hctx->run_work, 0);


-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/