Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752173AbbEDTaV (ORCPT ); Mon, 4 May 2015 15:30:21 -0400 Received: from mga03.intel.com ([134.134.136.65]:17908 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752134AbbEDTaI (ORCPT ); Mon, 4 May 2015 15:30:08 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,367,1427785200"; d="scan'208";a="720522361" Message-ID: <5547C7F0.5010905@intel.com> Date: Mon, 04 May 2015 12:26:40 -0700 From: Tadeusz Struk User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Herbert Xu CC: David Howells , corbet@lwn.net, keescook@chromium.org, qat-linux@intel.com, jwboyer@redhat.com, richard@nod.at, linux-kernel@vger.kernel.org, steved@redhat.com, vgoyal@redhat.com, james.l.morris@oracle.com, jkosina@suse.cz, zohar@linux.vnet.ibm.com, davem@davemloft.net, linux-crypto@vger.kernel.org Subject: Re: [PATCH RFC 1/2] crypto: add PKE API References: <20150430223652.10157.86151.stgit@tstruk-mobl1> <20150430223647.10157.82156.stgit@tstruk-mobl1> <4227.1430496240@warthog.procyon.org.uk> <5543C348.9060004@intel.com> <20150503000744.GB16211@gondor.apana.org.au> In-Reply-To: <20150503000744.GB16211@gondor.apana.org.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1603 Lines: 41 On 05/02/2015 05:07 PM, Herbert Xu wrote: >>>> > >> #define CRYPTO_ALG_TYPE_AHASH 0x0000000a >>>>> > >> > +#define CRYPTO_ALG_TYPE_PKE 0x0000000b >>>>> > >> > #define CRYPTO_ALG_TYPE_RNG 0x0000000c >>> > > Will filling a hole cause a problem with something that got obsoleted? >> > >> > I hope not. I checked as far back as 2.6.18 and I don't see any clash. >> > Herbert, what do you think? > Indeed you can't use this hole as it'll make you a hash algorithm. So in this case isn't RNG a hash algorithm as well? Anyway will something like this be ok with you: diff --git a/include/linux/crypto.h b/include/linux/crypto.h index ee14140..ac18cd3 100644 --- a/include/linux/crypto.h +++ b/include/linux/crypto.h @@ -41,7 +41,7 @@ /* * Algorithm masks and types. */ -#define CRYPTO_ALG_TYPE_MASK 0x0000000f +#define CRYPTO_ALG_TYPE_MASK 0xf000000f #define CRYPTO_ALG_TYPE_CIPHER 0x00000001 #define CRYPTO_ALG_TYPE_COMPRESS 0x00000002 #define CRYPTO_ALG_TYPE_AEAD 0x00000003 @@ -54,6 +54,7 @@ #define CRYPTO_ALG_TYPE_AHASH 0x0000000a #define CRYPTO_ALG_TYPE_RNG 0x0000000c #define CRYPTO_ALG_TYPE_PCOMPRESS 0x0000000f +#define CRYPTO_ALG_TYPE_PKE 0x10000001 #define CRYPTO_ALG_TYPE_HASH_MASK 0x0000000e #define CRYPTO_ALG_TYPE_AHASH_MASK 0x0000000c -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/