Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752130AbbEDT3Y (ORCPT ); Mon, 4 May 2015 15:29:24 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:38765 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751513AbbEDT3O (ORCPT ); Mon, 4 May 2015 15:29:14 -0400 Date: Mon, 4 May 2015 15:29:08 -0400 From: Sowmini Varadhan To: David Miller Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, chien.yen@oracle.com, rds-devel@oss.oracle.com, ajaykumar.hotchandani@oracle.com Subject: Re: [PATCH 1/2] net/rds: RDS-TCP: Always create a new rds_sock for an incoming connection. Message-ID: <20150504192908.GC26844@oracle.com> References: <20150504.144720.2228274897975931117.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150504.144720.2228274897975931117.davem@davemloft.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 721 Lines: 21 On (05/04/15 14:47), David Miller wrote: > > I think adding 64K of data to this module just to solve this rare > issue is excessive. I'd based that number mostly as a heuristic based on rds_conn_hash[]. Any suggestions for what's reasonable? 8K? Less? (BTW, I think that should be 32K, or am I mis-counting?) > Furthermore I don't see any locking protecting the hash table nor > the RDS socket linkage into that table. yes, I missed that, I'll fix that in v2. --Sowmini -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/