Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752130AbbEDUVr (ORCPT ); Mon, 4 May 2015 16:21:47 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:38894 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751036AbbEDUVi (ORCPT ); Mon, 4 May 2015 16:21:38 -0400 Date: Mon, 04 May 2015 16:21:34 -0400 (EDT) Message-Id: <20150504.162134.1761886048618680717.davem@davemloft.net> To: sowmini.varadhan@oracle.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, chien.yen@oracle.com, rds-devel@oss.oracle.com, ajaykumar.hotchandani@oracle.com Subject: Re: [PATCH 1/2] net/rds: RDS-TCP: Always create a new rds_sock for an incoming connection. From: David Miller In-Reply-To: <20150504192908.GC26844@oracle.com> References: <20150504.144720.2228274897975931117.davem@davemloft.net> <20150504192908.GC26844@oracle.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 04 May 2015 13:21:37 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 818 Lines: 22 From: Sowmini Varadhan Date: Mon, 4 May 2015 15:29:08 -0400 > On (05/04/15 14:47), David Miller wrote: >> >> I think adding 64K of data to this module just to solve this rare >> issue is excessive. > > I'd based that number mostly as a heuristic based on rds_conn_hash[]. > Any suggestions for what's reasonable? 8K? Less? > (BTW, I think that should be 32K, or am I mis-counting?) No table at all. There has to be another way to notice this kind of situation, how for example does NFS or any other sunrpc using service handle this case? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/