Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752475AbbEDUfI (ORCPT ); Mon, 4 May 2015 16:35:08 -0400 Received: from mail-qg0-f53.google.com ([209.85.192.53]:32807 "EHLO mail-qg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752431AbbEDUfA (ORCPT ); Mon, 4 May 2015 16:35:00 -0400 Message-ID: <5547D7F0.6000604@hurleysoftware.com> Date: Mon, 04 May 2015 16:34:56 -0400 From: Peter Hurley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Sascha Hauer CC: Robert Schwebel , kernel@pengutronix.de, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: earlycon: no match? References: <20150503211054.GR15254@pengutronix.de> <55477BC1.6000805@hurleysoftware.com> <20150504202223.GT6325@pengutronix.de> In-Reply-To: <20150504202223.GT6325@pengutronix.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1849 Lines: 57 On 05/04/2015 04:22 PM, Sascha Hauer wrote: > On Mon, May 04, 2015 at 10:01:37AM -0400, Peter Hurley wrote: >> Hi Robert, >> >> On 05/03/2015 05:10 PM, Robert Schwebel wrote: >>> Hi Peter, >>> >>> with 4.1-rc1, my boxes with early console enabled show something like >>> this (the example is vexpress, but it for example also happens on an >>> AM335x board): >>> >>> earlycon: no match for ttyAMA0,38400n8 >> >> This shouldn't impact any previous earlycon setup. Are you saying >> you're seeing a regression? >> >> How do you have early console enabled, via the command line or via DT? > > What happens here is that Robert has console=ttyAMA0,38400n8 in his > command line. Yeah, thanks, that much is now clear from his second email. > In init/main.c we have: > > static int __init do_early_param(char *param, char *val, const char *unused) > { > const struct obs_kernel_param *p; > > for (p = __setup_start; p < __setup_end; p++) { > if ((p->early && parameq(param, p->str)) || > (strcmp(param, "console") == 0 && > strcmp(p->str, "earlycon") == 0) > ) { > if (p->setup_func(val) != 0) > pr_warn("Malformed early option '%s'\n", param); > } > } > /* We accept everything at this stage. */ > return 0; > } > > This means that param_setup_earlycon() gets called with the arguments > passed to the console= parameter which makes no sense in this context > and leads to the "no match for" message. Right, except that "the context" has insufficient information to differentiate an error, such as a misspelled earlycon name, from any other use. Regards, Peter Hurley -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/