Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751541AbbEDVHV (ORCPT ); Mon, 4 May 2015 17:07:21 -0400 Received: from mga02.intel.com ([134.134.136.20]:2840 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750808AbbEDVHQ (ORCPT ); Mon, 4 May 2015 17:07:16 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,368,1427785200"; d="scan'208";a="566153585" Message-ID: <1430773535.5506.27.camel@spandruv-DESK3.jf.intel.com> Subject: Re: [PATCH v3] x86: punit_atom: punit device state debug driver From: Srinivas Pandruvada To: tglx@linutronix.de Cc: mingo@redhat.com, hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org, pebolle@tiscali.nl Date: Mon, 04 May 2015 14:05:35 -0700 In-Reply-To: <1430772593-20204-1-git-send-email-srinivas.pandruvada@linux.intel.com> References: <1430772593-20204-1-git-send-email-srinivas.pandruvada@linux.intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3091 Lines: 143 On Mon, 2015-05-04 at 13:49 -0700, Srinivas Pandruvada wrote: > v3 > Fixed biggest blunder > > consecutive read output root@VALLEYVIEW-C0-PLATFORM:/sys/kernel/debug/punit_atom# cat dev_power_state PUNIT NORTH COMPLEX DEVICES : GFX RENDER : D0i3 GFX MEDIA : D0i3 DISPLAY : D0i3 VED : D0i3 ISP : D0i3 MIO : D0 root@VALLEYVIEW-C0-PLATFORM:/sys/kernel/debug/punit_atom# cat dev_power_state PUNIT NORTH COMPLEX DEVICES : GFX RENDER : D0i3 GFX MEDIA : D0i3 DISPLAY : D0i3 VED : D0i3 ISP : D0i3 MIO : D0 root@VALLEYVIEW-C0-PLATFORM:/sys/kernel/debug/punit_atom# cat dev_power_state PUNIT NORTH COMPLEX DEVICES : GFX RENDER : D0i3 GFX MEDIA : D0i3 DISPLAY : D0i3 VED : D0i3 ISP : D0i3 MIO : D0 root@VALLEYVIEW-C0-PLATFORM:/sys/kernel/debug/punit_atom# cat dev_power_state PUNIT NORTH COMPLEX DEVICES : GFX RENDER : D0i3 GFX MEDIA : D0i3 DISPLAY : D0i3 VED : D0i3 ISP : D0i3 MIO : D0 root@VALLEYVIEW-C0-PLATFORM:/sys/kernel/debug/punit_atom# cat dev_power_state PUNIT NORTH COMPLEX DEVICES : GFX RENDER : D0i3 GFX MEDIA : D0i3 DISPLAY : D0i3 VED : D0i3 ISP : D0i3 MIO : D0 root@VALLEYVIEW-C0-PLATFORM:/sys/kernel/debug/punit_atom# cat dev_power_state PUNIT NORTH COMPLEX DEVICES : GFX RENDER : D0i3 GFX MEDIA : D0i3 DISPLAY : D0i3 VED : D0i3 ISP : D0i3 MIO : D0 root@VALLEYVIEW-C0-PLATFORM:/sys/kernel/debug/punit_atom# cat dev_power_state PUNIT NORTH COMPLEX DEVICES : GFX RENDER : D0i3 GFX MEDIA : D0i3 DISPLAY : D0i3 VED : D0i3 ISP : D0i3 MIO : D0 root@VALLEYVIEW-C0-PLATFORM:/sys/kernel/debug/punit_atom# cat dev_power_state PUNIT NORTH COMPLEX DEVICES : GFX RENDER : D0i3 GFX MEDIA : D0i3 DISPLAY : D0i3 VED : D0i3 ISP : D0i3 MIO : D0 root@VALLEYVIEW-C0-PLATFORM:/sys/kernel/debug/punit_atom# cat dev_power_state PUNIT NORTH COMPLEX DEVICES : GFX RENDER : D0i3 GFX MEDIA : D0i3 DISPLAY : D0i3 VED : D0i3 ISP : D0i3 MIO : D0 > > > v2 > Addressed Ingo Molnar's comments > - Fix commit message > - Added punit explanation > - Formatting comments > - Moved to arch/x86/platform/intel_mid > - changed the debugfs file name > > v1 > Based on review comments > - Changed to tristate instead of bool > - Moved config to kconfig.debug > - Added debug in module name > - Returning -ENXIO on debugfs file create error > > v0: > Base version > > > Srinivas Pandruvada (1): > x86: punit_atom: punit device state debug driver > > arch/x86/Kconfig.debug | 9 ++ > arch/x86/platform/intel-mid/Makefile | 2 + > arch/x86/platform/intel-mid/punit_atom_debug.c | 186 +++++++++++++++++++++++++ > 3 files changed, 197 insertions(+) > create mode 100644 arch/x86/platform/intel-mid/punit_atom_debug.c > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/