Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751984AbbEDVFi (ORCPT ); Mon, 4 May 2015 17:05:38 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:56176 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752808AbbEDVFc (ORCPT ); Mon, 4 May 2015 17:05:32 -0400 From: "Rafael J. Wysocki" To: Fabian Frederick Cc: linux-kernel@vger.kernel.org, "Rafael J. Wysocki" Subject: Re: [PATCH 1/1 linux-next] PNP: move EXPORT_SYMBOL after functions Date: Mon, 04 May 2015 23:30:33 +0200 Message-ID: <2355892.05HhS4M0WH@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.0.0+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1430582481-31606-1-git-send-email-fabf@skynet.be> References: <1430582481-31606-1-git-send-email-fabf@skynet.be> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 757 Lines: 21 On Saturday, May 02, 2015 06:01:21 PM Fabian Frederick wrote: > EXPORT macro must be placed directly after functions. > See Documentation/CodingStyle Chapter 6 Well, why is this change an improvement? Yes, it makes an old file follow the new(er) Documentation/CodingStyl, but what exactly is the benefit? Mind you, there are more files with EXPORT_SYMBOL(_GPL) at the end. Are you going to hunt for them now or something? -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/