Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751488AbbEDWft (ORCPT ); Mon, 4 May 2015 18:35:49 -0400 Received: from mail-ie0-f179.google.com ([209.85.223.179]:33878 "EHLO mail-ie0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750973AbbEDWfk convert rfc822-to-8bit (ORCPT ); Mon, 4 May 2015 18:35:40 -0400 MIME-Version: 1.0 X-Originating-IP: [50.206.43.50] In-Reply-To: <1430778649-28126-4-git-send-email-linux@roeck-us.net> References: <1430778649-28126-1-git-send-email-linux@roeck-us.net> <1430778649-28126-4-git-send-email-linux@roeck-us.net> Date: Mon, 4 May 2015 15:35:37 -0700 Message-ID: Subject: Re: [PATCH resend 3/5] xtensa: Provide dummy dma_alloc_attrs() and dma_free_attrs() From: Chris Zankel To: Guenter Roeck Cc: LKML , Geert Uytterhoeven , "linux-xtensa@linux-xtensa.org" , Max Filippov Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2264 Lines: 62 Hi Guenter, Sorry for the delay. Will work on it later today or tomorrow. Thanks, -Chris On Mon, May 4, 2015 at 3:30 PM, Guenter Roeck wrote: > xtensa:allmodconfig fails to build with the following errors. > > drivers/gpu/drm/nouveau/nvkm/subdev/instmem/gk20a.c: > In function ‘gk20a_instobj_dtor_dma’: > drivers/gpu/drm/nouveau/nvkm/subdev/instmem/gk20a.c:154:2: error: > implicit declaration of function ‘dma_free_attrs’ > drivers/gpu/drm/nouveau/nvkm/subdev/instmem/gk20a.c: > In function ‘gk20a_instobj_ctor_dma’: > drivers/gpu/drm/nouveau/nvkm/subdev/instmem/gk20a.c:218:2: error: > implicit declaration of function ‘dma_alloc_attrs’ > > Xtensa does not provide those functions at this time. > Provide dummy implementations to avoid build errors. > > Acked-by: Max Filippov > Signed-off-by: Guenter Roeck > --- > Please consider pushing this patch into mainline, or provide feedback > on how to improve it to be acceptable. > > arch/xtensa/include/asm/dma-mapping.h | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/xtensa/include/asm/dma-mapping.h b/arch/xtensa/include/asm/dma-mapping.h > index 172a02a6ad14..ba78ccf651e7 100644 > --- a/arch/xtensa/include/asm/dma-mapping.h > +++ b/arch/xtensa/include/asm/dma-mapping.h > @@ -185,4 +185,17 @@ static inline int dma_get_sgtable(struct device *dev, struct sg_table *sgt, > return -EINVAL; > } > > +static inline void *dma_alloc_attrs(struct device *dev, size_t size, > + dma_addr_t *dma_handle, gfp_t flag, > + struct dma_attrs *attrs) > +{ > + return NULL; > +} > + > +static inline void dma_free_attrs(struct device *dev, size_t size, > + void *vaddr, dma_addr_t dma_handle, > + struct dma_attrs *attrs) > +{ > +} > + > #endif /* _XTENSA_DMA_MAPPING_H */ > -- > 2.1.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/