Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751975AbbEDXrE (ORCPT ); Mon, 4 May 2015 19:47:04 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:38033 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751477AbbEDXq6 (ORCPT ); Mon, 4 May 2015 19:46:58 -0400 MIME-Version: 1.0 In-Reply-To: <6932657.HzjR3A75KT@vostro.rjw.lan> References: <20150428181203.35812.60474.stgit@dwillia2-desk3.amr.corp.intel.com> <2235175.7DaGPJD1E4@vostro.rjw.lan> <6932657.HzjR3A75KT@vostro.rjw.lan> Date: Mon, 4 May 2015 16:46:57 -0700 Message-ID: Subject: Re: [PATCH v2 02/20] libnd, nd_acpi: initial libnd infrastructure and NFIT support From: Dan Williams To: "Rafael J. Wysocki" Cc: "linux-nvdimm@lists.01.org" , Linux ACPI , "Rafael J. Wysocki" , Robert Moore , "linux-kernel@vger.kernel.org" , David Box Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1788 Lines: 38 On Mon, May 4, 2015 at 4:58 PM, Rafael J. Wysocki wrote: > On Friday, May 01, 2015 09:23:38 AM Dan Williams wrote: >> On Thu, Apr 30, 2015 at 6:21 PM, Rafael J. Wysocki wrote: >> > On Thursday, April 30, 2015 05:39:06 PM Dan Williams wrote: >> >> On Thu, Apr 30, 2015 at 4:23 PM, Rafael J. Wysocki wrote: [..] >> > If ND_E820 and ND_ACPI aren't mutually exclusive, I still don't see a good >> > enough reason for asking users about ND_ACPI. Why would I ever say "No" >> > here if I said "Yes" or "Module" to ND_DEVICES? >> >> I agree that if the user selects ND_DEVICES then ND_ACPI should >> probably default on, but otherwise turning it off is a useful option. >> If you know your system is pre-ACPI-6 then why bother including >> support? > > If you're a distro, you don't care. You have to support it regardless. > > You might care if you're an end user building a kernel for yourself and just > for this particular specific machine. Honestly, how many *server* users do > that? > > And fewer user-selectable options means fewer combination of options to test > during development/validation. > > Also unrelated, but applies to this patch. > > Since your new driver will handle device ID ACPI0012 which is defined by the > spec proper, it should go into drivers/acpi/, because there's where such things > go as a rule. Ok, I think the move to drivers/acpi/ will kill two birds with one stone as selecting ACPI_NFIT from there will select the libnd support without prompting. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/