Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751713AbbEEAgv (ORCPT ); Mon, 4 May 2015 20:36:51 -0400 Received: from ozlabs.org ([103.22.144.67]:53572 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751571AbbEEAgn (ORCPT ); Mon, 4 May 2015 20:36:43 -0400 Message-ID: <1430786200.13561.4.camel@ellerman.id.au> Subject: Re: [PATCH 2/2] selftests: Add membarrier syscall test From: Michael Ellerman To: Mathieu Desnoyers Cc: Andrew Morton , linux-kernel@vger.kernel.org, Pranith Kumar Date: Tue, 05 May 2015 10:36:40 +1000 In-Reply-To: <1430773213-8981-3-git-send-email-mathieu.desnoyers@efficios.com> References: <1430773213-8981-1-git-send-email-mathieu.desnoyers@efficios.com> <1430773213-8981-3-git-send-email-mathieu.desnoyers@efficios.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1575 Lines: 48 On Mon, 2015-05-04 at 17:00 -0400, Mathieu Desnoyers wrote: > From: Pranith Kumar > > This commit adds a selftest for the membarrier system call. > > diff --git a/tools/testing/selftests/membarrier/.gitignore b/tools/testing/selftests/membarrier/.gitignore > new file mode 100644 > index 0000000..020c44f4 > --- /dev/null > +++ b/tools/testing/selftests/membarrier/.gitignore > @@ -0,0 +1 @@ > +membarrier_test > diff --git a/tools/testing/selftests/membarrier/Makefile b/tools/testing/selftests/membarrier/Makefile > new file mode 100644 > index 0000000..752b719 > --- /dev/null > +++ b/tools/testing/selftests/membarrier/Makefile > @@ -0,0 +1,13 @@ > +CFLAGS += -g -D_FILE_OFFSET_BITS=64 > +CFLAGS += -I../../../../include/uapi/ > +CFLAGS += -I../../../../include/ Don't include the kernel headers, this is userspace. If you want to include the exported headers that would be good, they are in ../../../../usr/include by default. > +all: > + gcc $(CFLAGS) membarrier_test.c -o membarrier_test > + > +run_tests: all > + gcc $(CFLAGS) membarrier_test.c -o membarrier_test > + @./membarrier_test || echo "membarrier_test: [FAIL]" > + > +clean: > + $(RM) membarrier_test Can you please use lib.mk, it will do most of this for you, will support cross compilation, and install support as well. cheers -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/