Message-id: <5548617E.5040208@samsung.com>
Date: Tue, 05 May 2015 08:21:50 +0200
From: Robert Baldyga <r.baldyga@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101
 Thunderbird/31.6.0
MIME-version: 1.0
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: dan.j.williams@intel.com, vinod.koul@intel.com, lars@metafoo.de,
        dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
        m.szyprowski@samsung.com
Subject: Re: [PATCH 1/3] amba: add no_pm_pclk_management flag to amba_driver
References: <1429191554-24972-1-git-send-email-r.baldyga@samsung.com>
 <1429191554-24972-2-git-send-email-r.baldyga@samsung.com>
 <20150416134158.GZ12732@n2100.arm.linux.org.uk>
In-reply-to: <20150416134158.GZ12732@n2100.arm.linux.org.uk>
Content-type: text/plain; charset=windows-1252
Content-transfer-encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1078
Lines: 23

On 04/16/2015 03:41 PM, Russell King - ARM Linux wrote:
> On Thu, Apr 16, 2015 at 03:39:12PM +0200, Robert Baldyga wrote:
>> This patch introduces no_pm_pclk_management flag in struct amba_driver.
>> It causes that pclk is not touched in pm_runtime callbacks. This allows
>> to manage clock in device driver independently of power domain management.
> 
> NAK.  We already have stuff in place to deal with the problem with
> DMA engine using runtime PM, which causes pclk management to fall
> back to the IRQ-safe clk_enable/clk_disable().
> 

What kind of stuff do you mean? If we want to manage pclk independently
form runtime PM, we need to prevent AMBA driver from touching pclk.
Otherwise our clock management inside of dmaengine driver is ineffective
because pclk refcount is incremented by AMBA driver.

Thanks,
Robert Baldyga
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/