Message-ID: <1430807140.12261.7.camel@suse.de>
Subject: Re: [PATCH] USB: usbmon: Use 64bit timestamp for mon_bin_hdr
From: Oliver Neukum <oneukum@suse.de>
To: Tina Ruchandani <ruchandani.tina@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Tue, 05 May 2015 08:25:40 +0200
In-Reply-To: <20150505062056.GA4746@tinar>
References: <20150505062056.GA4746@tinar>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 703
Lines: 20

On Tue, 2015-05-05 at 11:50 +0530, Tina Ruchandani wrote:
> struct mon_bin_hdr allows for a 64-bit seconds timestamp. The code 
> currently uses 'struct timeval' to populate the timestamp in mon_bin_hdr, 
> which has a 32-bit seconds field and will overflow in year 2038 and beyond.
> This patch replaces 'struct timeval' with 'struct timespec64' which is 
> y2038 safe.

Hi,

but the timestamp will also overflow. So what is the point?

	Regards
		Oliver


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/