Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757042AbbEEIm4 (ORCPT ); Tue, 5 May 2015 04:42:56 -0400 Received: from terminus.zytor.com ([198.137.202.10]:47929 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751450AbbEEImr (ORCPT ); Tue, 5 May 2015 04:42:47 -0400 Date: Tue, 5 May 2015 01:42:34 -0700 From: tip-bot for Joonwoo Park Message-ID: Cc: linux-kernel@vger.kernel.org, john.stultz@linaro.org, tglx@linutronix.de, joonwoop@codeaurora.org, hpa@zytor.com, mingo@kernel.org Reply-To: linux-kernel@vger.kernel.org, tglx@linutronix.de, joonwoop@codeaurora.org, john.stultz@linaro.org, hpa@zytor.com, mingo@kernel.org In-Reply-To: <1430187709-21087-1-git-send-email-joonwoop@codeaurora.org> References: <1430187709-21087-1-git-send-email-joonwoop@codeaurora.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:timers/core] timer: Use timer->base for flag checks Git-Commit-ID: 781978e6e156101209f62b9ebc8783b70ef248de X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1689 Lines: 41 Commit-ID: 781978e6e156101209f62b9ebc8783b70ef248de Gitweb: http://git.kernel.org/tip/781978e6e156101209f62b9ebc8783b70ef248de Author: Joonwoo Park AuthorDate: Mon, 27 Apr 2015 19:21:49 -0700 Committer: Thomas Gleixner CommitDate: Tue, 5 May 2015 10:40:43 +0200 timer: Use timer->base for flag checks At present, internal_add_timer() examines flags with 'base' which doesn't contain flags. Examine with 'timer->base' to avoid unnecessary waking up of nohz CPU when timer base has TIMER_DEFERRABLE set. Signed-off-by: Joonwoo Park Cc: sboyd@codeaurora.org Cc: skannan@codeaurora.org Cc: John Stultz Link: http://lkml.kernel.org/r/1430187709-21087-1-git-send-email-joonwoop@codeaurora.org Signed-off-by: Thomas Gleixner --- kernel/time/timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/time/timer.c b/kernel/time/timer.c index 03f926c..d4af7c5 100644 --- a/kernel/time/timer.c +++ b/kernel/time/timer.c @@ -436,7 +436,7 @@ static void internal_add_timer(struct tvec_base *base, struct timer_list *timer) * require special care against races with idle_cpu(), lets deal * with that later. */ - if (!tbase_get_deferrable(base) || tick_nohz_full_cpu(base->cpu)) + if (!tbase_get_deferrable(timer->base) || tick_nohz_full_cpu(base->cpu)) wake_up_nohz_cpu(base->cpu); } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/