Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031065AbbEEIwW (ORCPT ); Tue, 5 May 2015 04:52:22 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:16948 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030918AbbEEIwQ (ORCPT ); Tue, 5 May 2015 04:52:16 -0400 Date: Tue, 5 May 2015 11:51:58 +0300 From: Dan Carpenter To: Jose Rivera Cc: "devel@driverdev.osuosl.org" , "agraf@suse.de" , "arnd@arndb.de" , "bhupesh.sharma@freescale.com" , "gregkh@linuxfoundation.org" , "linux-kernel@vger.kernel.org" , Stuart Yoder , Scott Wood , "nir.erez@freescale.com" , "itai.katz@freescale.com" , "bhamciu1@freescale.com" , "R89243@freescale.com" , Richard Schmitt Subject: Re: [PATCH 4/7] staging: fsl-mc: Upgraded MC bus driver to match MC fw 7.0.0 Message-ID: <20150505085158.GQ14154@mwanda> References: <1430242750-17745-1-git-send-email-German.Rivera@freescale.com> <1430242750-17745-5-git-send-email-German.Rivera@freescale.com> <20150430121251.GX14154@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1154 Lines: 34 On Mon, May 04, 2015 at 11:58:13PM +0000, Jose Rivera wrote: > > > > On Tue, Apr 28, 2015 at 12:39:07PM -0500, J. German Rivera wrote: > > > - Migrated MC bus driver to use DPRC flib 0.6. > > > > What does this mean? What is a flib? > > > The DPRC flib is the API to manipulate DPRC objects. > > > After reading the patch, apparently it means that we can remove all the > > ifdefs from patch 1. :) > > > No, we cannot as the required GIC-ITS support is not upstream yet. > I added some of the #ifdefs back that were removed by mistake. > > > > - Changed IRQ setup infrastructure to be able to program MSIs > > > for MC objects in an object-independent way. > > > > Are these two things related? > > > No. When I asked this function I was partly wondering why they were broken up the way they are. This changelog was not enough information to start reviewing the patch. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/