Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757306AbbEEJsl (ORCPT ); Tue, 5 May 2015 05:48:41 -0400 Received: from mga14.intel.com ([192.55.52.115]:17977 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751079AbbEEJsd (ORCPT ); Tue, 5 May 2015 05:48:33 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,372,1427785200"; d="scan'208";a="723872937" Message-ID: <554891EA.7050906@linux.intel.com> Date: Tue, 05 May 2015 15:18:26 +0530 From: Shobhit Kumar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Lee Jones , Shobhit Kumar CC: linux-pwm , Jani Nikula , Samuel Ortiz , Alexandre Courbot , Povilas Staniulis , intel-gfx , linux-kernel , dri-devel , linux-gpio , Daniel Vetter Subject: Re: [PATCH 5/8] drivers/mfd: ADD PWM lookup table for CRC PMIC based PWM References: <1430316005-16480-1-git-send-email-shobhit.kumar@intel.com> <1430316005-16480-6-git-send-email-shobhit.kumar@intel.com> <20150429142451.GS9169@x1> In-Reply-To: <20150429142451.GS9169@x1> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2909 Lines: 79 On 04/29/2015 07:54 PM, Lee Jones wrote: > On Wed, 29 Apr 2015, Shobhit Kumar wrote: > >> On some BYT PLatform the PWM is controlled using CRC PMIC. Add a lookup >> entry for the same to be used by the consumer (Intel GFX) >> >> v2: Remove the lookup table on driver unload (Thierry) >> >> CC: Samuel Ortiz >> Cc: Linus Walleij >> Cc: Alexandre Courbot >> Cc: Thierry Reding >> Signed-off-by: Shobhit Kumar >> --- >> drivers/mfd/intel_soc_pmic_core.c | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) > > How do you expect this set to be managed? There are some dependencies on the look up table remove functionality in earlier patches, so I think 3/8 can go in only after 1/8. Similarly 5/8 can go only after 2/8. Rest all can be independent. Regards Shobhit > > Acked-by: Lee Jones > >> diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c >> index f3d918e..a00ddd9 100644 >> --- a/drivers/mfd/intel_soc_pmic_core.c >> +++ b/drivers/mfd/intel_soc_pmic_core.c >> @@ -25,6 +25,7 @@ >> #include >> #include >> #include >> +#include >> #include "intel_soc_pmic_core.h" >> >> /* Lookup table for the Panel Enable/Disable line as GPIO signals */ >> @@ -37,6 +38,11 @@ static struct gpiod_lookup_table panel_gpio_table = { >> }, >> }; >> >> +/* PWM consumed by the Intel GFX */ >> +static struct pwm_lookup crc_pwm_lookup[] = { >> + PWM_LOOKUP("crystal_cove_pwm", 0, "0000:00:02.0", "pwm_backlight", 0, PWM_POLARITY_NORMAL), >> +}; >> + >> static int intel_soc_pmic_find_gpio_irq(struct device *dev) >> { >> struct gpio_desc *desc; >> @@ -99,6 +105,9 @@ static int intel_soc_pmic_i2c_probe(struct i2c_client *i2c, >> /* Add lookup table binding for Panel Control to the GPIO Chip */ >> gpiod_add_lookup_table(&panel_gpio_table); >> >> + /* Add lookup table for crc-pwm */ >> + pwm_add_table(crc_pwm_lookup, ARRAY_SIZE(crc_pwm_lookup)); >> + >> ret = mfd_add_devices(dev, -1, config->cell_dev, >> config->n_cell_devs, NULL, 0, >> regmap_irq_get_domain(pmic->irq_chip_data)); >> @@ -121,6 +130,9 @@ static int intel_soc_pmic_i2c_remove(struct i2c_client *i2c) >> /* Remove lookup table for Panel Control from the GPIO Chip */ >> gpiod_remove_lookup_table(&panel_gpio_table); >> >> + /* remove crc-pwm lookup table */ >> + pwm_remove_table(crc_pwm_lookup, ARRAY_SIZE(crc_pwm_lookup)); >> + >> mfd_remove_devices(&i2c->dev); >> >> return 0; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/