Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758039AbbEEKyw (ORCPT ); Tue, 5 May 2015 06:54:52 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:37238 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757991AbbEEKyo (ORCPT ); Tue, 5 May 2015 06:54:44 -0400 Date: Tue, 5 May 2015 11:54:39 +0100 From: Lee Jones To: Javier Martinez Canillas Cc: Gwendal Grignou , Olof Johansson , Doug Anderson , Bill Richardson , Simon Glass , Stephen Barber , Filipe Brandenburger , Todd Broch , linux-samsung-soc@vger.kernel.org, Linux Kernel Subject: Re: [RESEND PATCH 1/8] mfd: cros ec: Remove parent field Message-ID: <20150505105439.GB4047@x1> References: <1428336906-14906-1-git-send-email-javier.martinez@collabora.co.uk> <1428336906-14906-2-git-send-email-javier.martinez@collabora.co.uk> <20150429103734.GU9169@x1> <5548882A.50400@collabora.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5548882A.50400@collabora.co.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2011 Lines: 59 On Tue, 05 May 2015, Javier Martinez Canillas wrote: > On 04/29/2015 12:37 PM, Lee Jones wrote: > > On Thu, 23 Apr 2015, Gwendal Grignou wrote: > > > >> Be consistent, use cros_ec instead of "cros ec" or "cros-ec". > > > > What is this in reference to? > > > > I think Gwendal meant that I should be consistent in general and was not > referring to this patch particular. Better to quote one of the offending occurrences than to randomly top-post helpful comments. > >> Otherwise: > >> > >> Reviewed-by: Gwendal Grignou > >> Tested-by: Gwendal Grignou > >> > >> On Mon, Apr 6, 2015 at 9:14 AM, Javier Martinez Canillas > >> wrote: > >> > From: Gwendal Grignou > >> > > >> > parent and dev were pointing to the same device structure. > >> > parent is unused, removed. > >> > > >> > Signed-off-by: Gwendal Grignou > >> > Reviewed-by: Stephen Barber > >> > Tested-by: Stephen Barber > >> > Reviewed-by: Puthikorn Voravootivat > >> > Signed-off-by: Javier Martinez Canillas > >> > --- > >> > drivers/mfd/cros_ec_i2c.c | 1 - > >> > drivers/mfd/cros_ec_spi.c | 1 - > >> > drivers/platform/chrome/cros_ec_lpc.c | 1 - > >> > include/linux/mfd/cros_ec.h | 2 -- > >> > 4 files changed, 5 deletions(-) > > > > For when you re-submit: > > > > Acked-by: Lee Jones > > > > Thanks a lot for your ack. > > Best regards, > Javier -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/