Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161534AbbEELvw (ORCPT ); Tue, 5 May 2015 07:51:52 -0400 Received: from mail-pd0-f181.google.com ([209.85.192.181]:36267 "EHLO mail-pd0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161416AbbEELuI (ORCPT ); Tue, 5 May 2015 07:50:08 -0400 From: Ming Lei To: Jens Axboe , linux-kernel@vger.kernel.org Cc: "Justin M. Forbes" , Jeff Moyer , Tejun Heo , Christoph Hellwig , Ming Lei , stable@vger.kernel.org (v4.0) Subject: [PATCH 2/2] block: loop: avoiding too many pending per work I/O Date: Tue, 5 May 2015 19:49:55 +0800 Message-Id: <1430826595-5888-3-git-send-email-ming.lei@canonical.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1430826595-5888-1-git-send-email-ming.lei@canonical.com> References: <1430826595-5888-1-git-send-email-ming.lei@canonical.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1741 Lines: 50 If there are too many pending per work I/O, too many high priority work thread can be generated so that system performance can be effected. This patch limits the max_active parameter of workqueue as 16. This patch fixes Fedora 22 live booting performance regression when it is booted from squashfs over dm based on loop, and looks the following reasons are related with the problem: - not like other filesyststems(such as ext4), squashfs is a bit special, and I observed that increasing I/O jobs to access file in squashfs only improve I/O performance a little, but it can make big difference for ext4 - nested loop: both squashfs.img and ext3fs.img are mounted as loop block, and ext3fs.img is inside the squashfs - during booting, lots of tasks may run concurrently Fixes: b5dd2f6047ca108001328aac0e8588edd15f1778 Cc: stable@vger.kernel.org (v4.0) Cc: Justin M. Forbes Signed-off-by: Ming Lei --- drivers/block/loop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/loop.c b/drivers/block/loop.c index 3dc1598..1bee523 100644 --- a/drivers/block/loop.c +++ b/drivers/block/loop.c @@ -725,7 +725,7 @@ static int loop_set_fd(struct loop_device *lo, fmode_t mode, goto out_putf; error = -ENOMEM; lo->wq = alloc_workqueue("kloopd%d", - WQ_MEM_RECLAIM | WQ_HIGHPRI | WQ_UNBOUND, 0, + WQ_MEM_RECLAIM | WQ_HIGHPRI | WQ_UNBOUND, 16, lo->lo_number); if (!lo->wq) goto out_putf; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/