MIME-Version: 1.0
In-Reply-To: <5547E996.30078.8008582@pageexec.freemail.hu>
References: <1430774218-5311-1-git-send-email-anisse@astier.eu>
 <1430774218-5311-3-git-send-email-anisse@astier.eu> <5547E996.30078.8008582@pageexec.freemail.hu>
From: Anisse Astier <anisse@astier.eu>
Date: Tue, 5 May 2015 14:42:11 +0200
Message-ID: <CALUN=qJHsagU66CH0CakdmKae8eSnmb9jtqrHfNo_3f4ECSMMg@mail.gmail.com>
Subject: Re: [PATCH v2 2/4] mm/page_alloc.c: add config option to sanitize
 freed pages
To: PaX Team <pageexec@freemail.hu>
Cc: Andrew Morton <akpm@linux-foundation.org>, Mel Gorman <mgorman@suse.de>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        David Rientjes <rientjes@google.com>,
        Alan Cox <gnomes@lxorguk.ukuu.org.uk>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Brad Spengler <spender@grsecurity.net>,
        Kees Cook <keescook@chromium.org>, Andi Kleen <andi@firstfloor.org>,
        linux-mm@kvack.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1186
Lines: 27

On Mon, May 4, 2015 at 11:50 PM, PaX Team <pageexec@freemail.hu> wrote:
> On 4 May 2015 at 23:16, Anisse Astier wrote:
>
>> @@ -960,9 +966,15 @@ static int prep_new_page(struct page *page, unsigned int order, gfp_t gfp_flags,
>>       kernel_map_pages(page, 1 << order, 1);
>>       kasan_alloc_pages(page, order);
>>
>> +#ifndef CONFIG_SANITIZE_FREED_PAGES
>> +     /* SANITIZE_FREED_PAGES relies implicitly on the fact that pages are
>> +      * cleared before use, so we don't need gfp zero in the default case
>> +      * because all pages go through the free_pages_prepare code path when
>> +      * switching from bootmem to the default allocator */
>>       if (gfp_flags & __GFP_ZERO)
>>               for (i = 0; i < (1 << order); i++)
>>                       clear_highpage(page + i);
>> +#endif
>
> this hunk should not be applied before the hibernation fix otherwise
> bisect will break.
>

It will be re-ordered in v3, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/