Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423134AbbEEM5n (ORCPT ); Tue, 5 May 2015 08:57:43 -0400 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:54024 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423101AbbEEM5X (ORCPT ); Tue, 5 May 2015 08:57:23 -0400 Message-ID: <1430830630.4113.214.camel@decadent.org.uk> Subject: Re: [PATCH 3.2 042/221] ALSA: hdspm - Constrain periods to 2 on older cards From: Ben Hutchings To: Adrian Knoth Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, akpm@linux-foundation.org, Takashi Iwai Date: Tue, 05 May 2015 13:57:10 +0100 In-Reply-To: <5548BB98.3080502@drcomp.erfurt.thur.de> References: <5548BB98.3080502@drcomp.erfurt.thur.de> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-MlOsX8zXYK0Pl1uO+zTb" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 192.168.4.249 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3254 Lines: 97 --=-MlOsX8zXYK0Pl1uO+zTb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2015-05-05 at 14:46 +0200, Adrian Knoth wrote: > On 05/05/15 03:16, Ben Hutchings wrote: >=20 > > 3.2.69-rc1 review patch. If anyone has any objections, please let me k= now. >=20 > I do! :) >=20 > >=20 > > From: Adrian Knoth > >=20 > > commit f0153c3d948c1764f6c920a0675d86fc1d75813e upstream. > >=20 > > RME RayDAT and AIO use a fixed buffer size of 16384 samples. With perio= d > > sizes of 32-4096, this translates to 4-512 periods. > >=20 > > The older RME cards have a variable buffer size but require exactly two > > periods. > >=20 > > This patch enforces nperiods=3D2 on those cards. > >=20 > > Signed-off-by: Adrian Knoth > > Signed-off-by: Takashi Iwai > > Signed-off-by: Ben Hutchings > > --- > > sound/pci/rme9652/hdspm.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > >=20 > > --- a/sound/pci/rme9652/hdspm.c > > +++ b/sound/pci/rme9652/hdspm.c > > @@ -6040,6 +6040,12 @@ static int snd_hdspm_capture_open(struct > > snd_pcm_hw_constraint_minmax(runtime, > > SNDRV_PCM_HW_PARAM_PERIOD_SIZE, > > 64, 8192); > > + snd_pcm_hw_constraint_minmax(runtime, > > + SNDRV_PCM_HW_PARAM_PERIODS, > > + 2, 2); > > + snd_pcm_hw_constraint_minmax(runtime, > > + SNDRV_PCM_HW_PARAM_PERIODS, > > + 2, 2); > > break; > > } >=20 > This is not correct, those lines need to go to two different functions > (snd_hdspm_playback_open and snd_hdspm_capture_open) >=20 > Here is how the patch should look like: Thanks, I've now fixed it. [...] > PS: This exact same problem happened to GregKH for one of his stable > branches. Not sure what's the root cause and if it's worth > investigating. It's a bug in patch: https://bugs.debian.org/717782 Ben. --=20 Ben Hutchings Once a job is fouled up, anything done to improve it makes it worse. --=-MlOsX8zXYK0Pl1uO+zTb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIVAwUAVUi+K+e/yOyVhhEJAQpzIg//WhUrTAe2DVA3quybbIfeOKkI7W/O7PiL CvPvXi7G7dHgjwAryXzTiPJZZLVUys3Ydwlwa+OYD/JE1K3CpWaltpAB8tQZFKe8 ogZlXHOR3p715GsF9y4+nrLPBMl1y8BlTDYWlUaUtCyTjXiLnpTQFPjMYEzUfjje 5yZso19iciYo92Mi2+7m+fv/Bh6iHakvgi4HZ8Pjp/ZXM5wUdLVDrNe/ajSIw4Hd 5JS7w3zOo8PPN4IIw/6CqPcJp0HbifDCpoTMaqUAba0zmu4mbAMAm6MBP916C0PM 4ArRlVUsGFrcx4YygvfSGekBQIYdh3fcjnGzX6SSAdn7MrTcPkqO7KQPe6+43teA j9E2DQ4THULkPGAGBZei6Qtnt633caFwTg/uuZ06N9g9TTaUnUcXwYY61pzfX4d/ 98rAD4ZTOuXmYNNpo2k/ewKCPpg9KJgnF9PFoL8R3pr+Dh/fkHWBLpcVsdTkAQLR he57XXybca7crS1lARPz0e6KDLW8IxsRjoy4wYAFImK+Q5gMz4BMEkFrwrG9lfM2 pHEcoJ42pEdi8i0sCgixSPXaSVLXjlg6QPNUoNCj3VXr5pMjuMEDnQ11RzOofB9Y U7gA0qTLROZON0xGgemwgywaZd22HT0RsgudowVKdXwH4PvdF2THjNyp0+s+SFFo lSMChaM4YNk= =XhFq -----END PGP SIGNATURE----- --=-MlOsX8zXYK0Pl1uO+zTb-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/