Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423236AbbEENDV (ORCPT ); Tue, 5 May 2015 09:03:21 -0400 Received: from outbound-smtp04.blacknight.com ([81.17.249.35]:49239 "EHLO outbound-smtp04.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423218AbbEENDM (ORCPT ); Tue, 5 May 2015 09:03:12 -0400 Message-ID: <5548BF89.3060705@nexus-software.ie> Date: Tue, 05 May 2015 06:03:05 -0700 From: "Bryan O'Donoghue" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Paul Bolle CC: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, dvhart@infradead.org, andy.schevchenko@gmail.com, boon.leong.ong@intel.com, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, derek.browne@intel.com, josef.ahmad@intel.com, erik.nyquist@intel.com Subject: Re: [PATCH 1/2] x86/quark: Add Quark embedded SRAM support References: <1430705875-6990-1-git-send-email-pure.logic@nexus-software.ie> <1430705875-6990-2-git-send-email-pure.logic@nexus-software.ie> <1430815487.3843.24.camel@x220> In-Reply-To: <1430815487.3843.24.camel@x220> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1159 Lines: 32 On 05/05/15 01:44, Paul Bolle wrote: > On Mon, 2015-05-04 at 03:17 +0100, Bryan O'Donoghue wrote: >> --- a/arch/x86/platform/intel-quark/Makefile >> +++ b/arch/x86/platform/intel-quark/Makefile > >> obj-$(CONFIG_INTEL_IMR) += imr.o > > (Your change to drivers/platform/x86/Kconfig now makes it possible that > imr.o will be part of a module. More on that below.) > >> +obj-$(CONFIG_INTEL_ESRAM) += esram.o > > INTEL_ESRAM is a bool Kconfig symbol, so esram.o will never be part of a > module, right? Nope - this is kak that is hanging around in my git repo for no good reason. No intention to make IMRs modules (and in fact everything would break if they were). Thanks - no idea how that crept in :) > Was your intention perhaps to make this a tristate symbol? No I think I was making esram tristate for test purposes - edited the wrong line - and then didn't scrub it before the patchseries :( Cheers ! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/