Date: Tue, 5 May 2015 14:31:29 +0100
From: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
To: Mark Brown <broonie@kernel.org>
Cc: lee.jones@linaro.org, linus.walleij@linaro.org, gnurou@gmail.com,
        cw00.choi@samsung.com, myungjoo.ham@samsung.com,
        devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
        patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org,
        linux-gpio@vger.kernel.org, ckeepax@opensource.wolfsonmicro.com
Subject: Re: [PATCH v3 7/8] ASoC: wm8998: Initial WM8998 codec driver
Message-ID: <20150505133129.GA26101@opensource.wolfsonmicro.com>
References: <1430493319-23808-1-git-send-email-rf@opensource.wolfsonmicro.com> <1430493319-23808-8-git-send-email-rf@opensource.wolfsonmicro.com> <20150504113943.GB15510@sirena.org.uk> <20150505092411.GA15549@opensource.wolfsonmicro.com> <20150505105327.GZ22845@sirena.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150505105327.GZ22845@sirena.org.uk>
User-Agent: Mutt/1.5.17+20080114 (2008-01-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1353
Lines: 29

> 
> > > > +static const char * const wm8998_inmux_texts[] = {
> > > > +	"A",
> > > > +	"B",
> 
> > > Those are some fun input names...
> 
> > ... that's what the mux positions are called and it seems nice to have consistent
> > naming for all similar muxes across channels and across future codecs. Like for
> > example to switch both muxes of a stereo input you set them both to the same
> > position name (both "A" or both "B") is clearer, and quicker to spot in a dump
> > of ALSA control settings, than having the two muxes set to different enumeration
> > strings that actually mean the same mux position.
> 
> Equally when setting the muxes settings called A and B that's not really
> telling people what they do.

We can't really tell people what the selection does because that depends on
the external hardware. The A setting might be a headset mic, or a line in,
or a builtin mic...

All we can do is say what the selection is called generically by the codec.
So take the IN1L signal, on the codec it has two inputs "A" and "B". The
IN1L Mux control has two settings "A" and "B". That seems clear.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/