Message-ID: <1430835520.7191.14.camel@perches.com>
Subject: Re: [PATCH v2 3/5] toshiba_acpi: Cleanup blank lines after comment
 blocks
From: Joe Perches <joe@perches.com>
To: Azael Avalos <coproscefalo@gmail.com>
Cc: Darren Hart <dvhart@infradead.org>, platform-driver-x86@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date: Tue, 05 May 2015 07:18:40 -0700
In-Reply-To: <1430759758-4026-4-git-send-email-coproscefalo@gmail.com>
References: <1430759758-4026-1-git-send-email-coproscefalo@gmail.com>
	 <1430759758-4026-4-git-send-email-coproscefalo@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1125
Lines: 43

On Mon, 2015-05-04 at 11:15 -0600, Azael Avalos wrote:
> This patch removes some blank lines after comment blocks, capitalizes
> some comments first words and adds a few comments to the beggining
> of some functions.

I think blank lines after comments are generally OK.

This is now inconsistent about 

/*
 * short comment
 */

and

/* short comment */

Not all function blocks need introductory comments.

> diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c
[]
> @@ -78,10 +78,9 @@ MODULE_LICENSE("GPL");
>   * SCI stands for "System Configuration Interface" which aim is to
>   * conceal differences in hardware between different models.
>   */
> -
>  #define TCI_WORDS			6

It's sometimes nice to have blank lines after long
block comments.
 
> -/* operations */
> +/* Operations */

I think these sentence case changes aren't better.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/