Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2994149AbbEEQIN (ORCPT ); Tue, 5 May 2015 12:08:13 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:50656 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S2993259AbbEEOwe (ORCPT ); Tue, 5 May 2015 10:52:34 -0400 Date: Tue, 5 May 2015 10:52:33 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Tina Ruchandani cc: Oliver Neukum , Arnd Bergmann , Greg Kroah-Hartman , linux-usb , Linux Kernel List Subject: Re: [PATCH] USB: usbmon: Use 64bit timestamp for mon_bin_hdr In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 990 Lines: 26 On Mon, 4 May 2015, Tina Ruchandani wrote: > > but the timestamp will also overflow. So what is the point? > > > > The 32-bit timestamp obtained using do_gettimeofday() will overflow in > year 2038. However, with 64-bit timestamps, we get practically > infinite time. mon_bin_hdr already has support for a 64-bit seconds > timestamp. This patch changes how it is populated. Surely the real point was mentioned in the patch description: > ... This patch is part of a larger > attempt to remove instances of struct timeval and other 32-bit timekeeping > (time_t, struct timespec) from the kernel. The point is to get rid of 32-bit timekeeping routines. Overflow and the exact nature of the timestamps in usbmon are irrelevant. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/