Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759550AbbEEQIz (ORCPT ); Tue, 5 May 2015 12:08:55 -0400 Received: from mail-ig0-f172.google.com ([209.85.213.172]:38482 "EHLO mail-ig0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2993313AbbEEPJG (ORCPT ); Tue, 5 May 2015 11:09:06 -0400 MIME-Version: 1.0 In-Reply-To: <1430803373-4948-40-git-send-email-viro@ZenIV.linux.org.uk> References: <20150505052205.GS889@ZenIV.linux.org.uk> <1430803373-4948-40-git-send-email-viro@ZenIV.linux.org.uk> Date: Tue, 5 May 2015 08:09:04 -0700 X-Google-Sender-Auth: o8L46OB_xojdaaAZgTBMTGnD3GE Message-ID: Subject: Re: [PATCH 40/79] link_path_walk: turn inner loop into explicit goto From: Linus Torvalds To: Al Viro Cc: Neil Brown , Christoph Hellwig , Linux Kernel Mailing List , linux-fsdevel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 750 Lines: 19 On Mon, May 4, 2015 at 10:22 PM, Al Viro wrote: > +l: This looked like noise. PLEASE. We're not programming in Pascal (and thank all Gods for that), so we can have labels that have meaningful names. Also, we're not ashamed of using goto where it makes sense, so we don't need to try to hide the labels by making them look like specks of dirt on our monitor. So give the label a real name that describes what it is. Not this kind of thing. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/