Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759595AbbEEQJE (ORCPT ); Tue, 5 May 2015 12:09:04 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:41648 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2993320AbbEEPLU (ORCPT ); Tue, 5 May 2015 11:11:20 -0400 Date: Tue, 5 May 2015 16:10:53 +0100 From: Al Viro To: Linus Torvalds Cc: Neil Brown , Christoph Hellwig , Linux Kernel Mailing List , linux-fsdevel Subject: Re: [PATCH 04/79] ext4: split inode_operations for encrypted symlinks off the rest Message-ID: <20150505151052.GT889@ZenIV.linux.org.uk> References: <20150505052205.GS889@ZenIV.linux.org.uk> <1430803373-4948-4-git-send-email-viro@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 885 Lines: 18 On Tue, May 05, 2015 at 08:01:52AM -0700, Linus Torvalds wrote: > Ugh. Could we aim to *not* add code like this. > > Instead, just declare (but don't define) the > ext4_encrypted_symlink_inode_operations thing, so that *if* somebody > uses it they get a link error, and make sure that > "ext4_encrypted_inode()" ends up always returning zero when encryption > isn't enabled, so that the compiler will actually optimize the whole > thing out (which apparently is already the case, judging by the > build-bug-on. Sure, no problem. BUILD_BUG_ON was used only because it triggered an error earlier, I simply forgot to rip it out afterwards. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/