Message-ID: <5548E02A.5050006@suse.cz>
Date: Tue, 05 May 2015 17:22:18 +0200
From: Michal Marek <mmarek@suse.cz>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Linus Torvalds <torvalds@linux-foundation.org>,
        David Howells <dhowells@redhat.com>
CC: Abelardo Ricart III <aricart@memnix.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Sedat Dilek <sedat.dilek@gmail.com>, keyrings@linux-nfs.org,
        Rusty Russell <rusty@rustcorp.com.au>,
        LSM List <linux-security-module@vger.kernel.org>,
        James Morris <james.l.morris@oracle.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] MODSIGN: Change default key details [ver #2]
References: <CA+55aFyr4EufCSpS3egCN3hcWwvgp60uwn6cxxC7=jZTGBPYzA@mail.gmail.com>	<1430516505-4812-1-git-send-email-aricart@memnix.com>	<CA+55aFyJ4Bx8TUmpOyFMHmm5gnZ3AegBW9EyhrcVpOsoMP9UxQ@mail.gmail.com>	<1430559977.5803.12.camel@memnix.com>	<CA+55aFyTHjPdSgQv2iZuW7VG1bCTGMGwqcNwa1sjm9V6RkXFNw@mail.gmail.com> <CA+55aFw1Oj-+nyjQevCHLDq8j3xQ7zixgUEd-bTp+z49y60fUw@mail.gmail.com>
In-Reply-To: <CA+55aFw1Oj-+nyjQevCHLDq8j3xQ7zixgUEd-bTp+z49y60fUw@mail.gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1273
Lines: 33

On 2015-05-04 20:45, Linus Torvalds wrote:
> On Sun, May 3, 2015 at 6:45 PM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
>>
>> I'd much rather see "x509.genkey" be generated with a move-if-changed
>> pattern, so that it only changes if (a) it didn't exist before or (b)
>> it actually has new content.
> 
> Hmm. Something like the attached, to make the .x509.list file be
> properly generated?
> 
> That still leaves the problem that the X509_CERTIFICATES variable
> itself seems to be badly defined, in that it ends up randomly having
> the "./" in front of the filename due to confusion between
> "signing_key.x509" being both in
> 
>    X509_CERTIFICATES-y := $(wildcard *.x509) $(wildcard $(srctree)/*.x509)
> 
> (when that .x509 file was pre-existing), and
> 
>    X509_CERTIFICATES-$(CONFIG_MODULE_SIG) += $(objtree)/signing_key.x509
> 
> where I think that "$(objtree)/" comes in.

This will be fixed once https://lkml.org/lkml/2015/2/20/546 is merged
(the two patches are independent of each other).

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/