Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760156AbbEEQLE (ORCPT ); Tue, 5 May 2015 12:11:04 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:35938 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2993437AbbEEPmm (ORCPT ); Tue, 5 May 2015 11:42:42 -0400 Date: Tue, 5 May 2015 17:44:59 +0200 From: Daniel Vetter To: Lee Jones Cc: Shobhit Kumar , linux-pwm , Jani Nikula , Samuel Ortiz , Alexandre Courbot , David Airlie , Povilas Staniulis , intel-gfx , linux-kernel , dri-devel , linux-gpio , Chih-Wei Huang , Thierry Reding , Daniel Vetter , Linus Walleij Subject: Re: [Intel-gfx] [PATCH 1/8] gpiolib: Add support for removing registered consumer lookup table Message-ID: <20150505154459.GC30184@phenom.ffwll.local> Mail-Followup-To: Lee Jones , Shobhit Kumar , linux-pwm , Jani Nikula , Samuel Ortiz , Alexandre Courbot , David Airlie , Povilas Staniulis , intel-gfx , linux-kernel , dri-devel , linux-gpio , Chih-Wei Huang , Thierry Reding , Daniel Vetter , Linus Walleij References: <1430316005-16480-2-git-send-email-shobhit.kumar@intel.com> <1430818368-26790-1-git-send-email-shobhit.kumar@intel.com> <20150505104505.GZ4047@x1> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150505104505.GZ4047@x1> X-Operating-System: Linux phenom 4.0.0-rc3+ User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3340 Lines: 91 On Tue, May 05, 2015 at 11:45:05AM +0100, Lee Jones wrote: > This is not how we submit subsequent patch-sets. It is unfortunately how we handle patches on dri-devel&intel-gfx to be able to cope with massive mail load. If everyone who submits to intel-gfx would always resend the entire series for minor updates of som patches we'd completely drown in the resulting flood. > Please submit them as a whole, seperately from the first submission > and with versioning information i.e. [PATCH v2 X/Y] Stuff ... > > > In case we unload and load a driver module again that is registering a > > lookup table, without this it will result in multiple entries. Provide > > an option to remove the lookup table on driver unload > > > > v2: Ccing maintainers > > v3: Correct the subject line (Lee jones) > > Change logs should go underneth the '---' and above the diffstat found > below. Again just style differences between subsystems, I generally want to have those above the ---. -Daniel > > > Cc: Samuel Ortiz > > Cc: Linus Walleij > > Cc: Alexandre Courbot > > Cc: Thierry Reding > > Reviewed-by: Alexandre Courbot > > Signed-off-by: Shobhit Kumar > > --- > > drivers/gpio/gpiolib.c | 13 +++++++++++++ > > include/linux/gpio/machine.h | 1 + > > 2 files changed, 14 insertions(+) > > > > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > > index 59eaa23..2420af9 100644 > > --- a/drivers/gpio/gpiolib.c > > +++ b/drivers/gpio/gpiolib.c > > @@ -1658,6 +1658,19 @@ void gpiod_add_lookup_table(struct gpiod_lookup_table *table) > > mutex_unlock(&gpio_lookup_lock); > > } > > > > +/** > > + * gpiod_remove_lookup_table() - unregister GPIO device consumers > > + * @table: table of consumers to unregister > > + */ > > +void gpiod_remove_lookup_table(struct gpiod_lookup_table *table) > > +{ > > + mutex_lock(&gpio_lookup_lock); > > + > > + list_del(&table->list); > > + > > + mutex_unlock(&gpio_lookup_lock); > > +} > > + > > static struct gpio_desc *of_find_gpio(struct device *dev, const char *con_id, > > unsigned int idx, > > enum gpio_lookup_flags *flags) > > diff --git a/include/linux/gpio/machine.h b/include/linux/gpio/machine.h > > index e270614..c0d712d 100644 > > --- a/include/linux/gpio/machine.h > > +++ b/include/linux/gpio/machine.h > > @@ -57,5 +57,6 @@ struct gpiod_lookup_table { > > } > > > > void gpiod_add_lookup_table(struct gpiod_lookup_table *table); > > +void gpiod_remove_lookup_table(struct gpiod_lookup_table *table); > > > > #endif /* __LINUX_GPIO_MACHINE_H */ > > -- > Lee Jones > Linaro STMicroelectronics Landing Team Lead > Linaro.org │ Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/