Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1761433AbbEEQeI (ORCPT <rfc822;w@1wt.eu>);
	Tue, 5 May 2015 12:34:08 -0400
Received: from mail4.hitachi.co.jp ([133.145.228.5]:55630 "EHLO
	mail4.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1761322AbbEEQeE (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 5 May 2015 12:34:04 -0400
Message-ID: <5548F0F2.6030505@hitachi.com>
Date: Wed, 06 May 2015 01:33:54 +0900
From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Organization: Hitachi, Ltd., Japan
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Arnaldo Carvalho de Melo <acme@kernel.org>
CC: Wang Nan <wangnan0@huawei.com>, ast@plumgrid.com, davem@davemloft.net,
        mingo@redhat.com, a.p.zijlstra@chello.nl, jolsa@kernel.org,
        lizefan@kernel.org, linux-kernel@vger.kernel.org, pi3orama@163.com,
        hekuang@huawei.com
Subject: Re: [RFC PATCH 01/22] perf: probe: avoid segfault if passed with
 ''.
References: <1430391165-30267-1-git-send-email-wangnan0@huawei.com> <1430391165-30267-2-git-send-email-wangnan0@huawei.com> <5548CF11.9000400@hitachi.com> <20150505152632.GU10475@kernel.org>
In-Reply-To: <20150505152632.GU10475@kernel.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1544
Lines: 51

On 2015/05/06 0:26, Arnaldo Carvalho de Melo wrote:
> Em Tue, May 05, 2015 at 11:09:21PM +0900, Masami Hiramatsu escreveu:
>> On 2015/04/30 19:52, Wang Nan wrote:
>>> Since parse_perf_probe_point() deals with a user passed argument, we
>>> should not assume it to be a valid string.
>>>
>>> Without this patch, if pass '' to perf probe, a segfault raises:
>>>
>>>  $ perf probe -a ''
>>>  Segmentation fault
> 
>>> This patch checks argument of parse_perf_probe_point() before
>>> string processing.
> 
>>> After this patch:
> 
>>>  $ perf probe -a ''
>>>
>>>   usage: perf probe [<options>] 'PROBEDEF' ['PROBEDEF' ...]
>>>      or: perf probe [<options>] --add 'PROBEDEF' [--add 'PROBEDEF' ...]
>>>      ...
>  
>> This looks OK to me.
>  
>> Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
>  
>> Could you split this as an independent bugfix with my ack?
> 
> You mean split from this patchkit? I already did that, added it to my
> perf/urgent branch, where I'll add your acked-by as well,

Ah, you've done it! I missed it.

Thanks!

> 
> - Arnaldo
> 


-- 
Masami HIRAMATSU
Linux Technology Research Center, System Productivity Research Dept.
Center for Technology Innovation - Systems Engineering
Hitachi, Ltd., Research & Development Group
E-mail: masami.hiramatsu.pt@hitachi.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/