Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761616AbbEERAO (ORCPT ); Tue, 5 May 2015 13:00:14 -0400 Received: from foss.arm.com ([217.140.101.70]:45388 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760845AbbEERAM (ORCPT ); Tue, 5 May 2015 13:00:12 -0400 Date: Tue, 5 May 2015 18:00:06 +0100 From: Will Deacon To: Hou Pengyang Cc: "a.p.zijlstra@chello.nl" , "paulus@samba.org" , "acme@kernel.org" , "mingo@redhat.com" , "wangnan0@huawei.com" , Catalin Marinas , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v3 2/2] arm64: perf: Fix callchain parse error with kernel tracepoint events Message-ID: <20150505170006.GM1550@arm.com> References: <1430546297-80481-1-git-send-email-houpengyang@huawei.com> <1430546297-80481-3-git-send-email-houpengyang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1430546297-80481-3-git-send-email-houpengyang@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2597 Lines: 65 On Sat, May 02, 2015 at 06:58:17AM +0100, Hou Pengyang wrote: > For ARM64, when tracing with tracepoint events, the IP and pstate are set > to 0, preventing the perf code parsing the callchain and resolving the > symbols correctly. > > ./perf record -e sched:sched_switch -g --call-graph dwarf ls > [ perf record: Captured and wrote 0.146 MB perf.data ] > ./perf report -f > Samples: 194 of event 'sched:sched_switch', Event count (approx.): 194 > Children Self Command Shared Object Symbol > 100.00% 100.00% ls [unknown] [.] 0000000000000000 > > The fix is to implement perf_arch_fetch_caller_regs for ARM64, which fills > several necessary registers used for callchain unwinding, including pc,sp, > fp and spsr . > > With this patch, callchain can be parsed correctly as follows: > > ...... > + 2.63% 0.00% ls [kernel.kallsyms] [k] vfs_symlink > + 2.63% 0.00% ls [kernel.kallsyms] [k] follow_down > + 2.63% 0.00% ls [kernel.kallsyms] [k] pfkey_get > + 2.63% 0.00% ls [kernel.kallsyms] [k] do_execveat_common.isra.33 > - 2.63% 0.00% ls [kernel.kallsyms] [k] pfkey_send_policy_notify > pfkey_send_policy_notify > pfkey_get > v9fs_vfs_rename > page_follow_link_light > link_path_walk > el0_svc_naked > ....... > > Signed-off-by: Hou Pengyang > --- > arch/arm64/include/asm/perf_event.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm64/include/asm/perf_event.h b/arch/arm64/include/asm/perf_event.h > index d26d1d5..cc92021 100644 > --- a/arch/arm64/include/asm/perf_event.h > +++ b/arch/arm64/include/asm/perf_event.h > @@ -24,4 +24,11 @@ extern unsigned long perf_misc_flags(struct pt_regs *regs); > #define perf_misc_flags(regs) perf_misc_flags(regs) > #endif > > +#define perf_arch_fetch_caller_regs(regs, __ip) { \ > + (regs)->ARM_pc = (__ip); \ > + (regs)->ARM_fp = (unsigned long) __builtin_frame_address(0); \ > + (regs)->ARM_sp = current_stack_pointer; \ > + (regs)->ARM_cpsr = PSR_MODE_EL1h; \ > +} This can't possibly compile, therefore you can't possibly have tested it. Please fix the code and actually check that you're getting sensible callchains before sending a new version of the patch. Thanks, Will -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/