Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965747AbbEERKj (ORCPT ); Tue, 5 May 2015 13:10:39 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.161]:62818 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965729AbbEERKh (ORCPT ); Tue, 5 May 2015 13:10:37 -0400 X-RZG-AUTH: :ImkWY2CseuihIZy6ZWWciR6unPh5JPSWE7VxbdUCFBN5njG7Q28CH4RMeHzjXw== X-RZG-CLASS-ID: mo00 Message-ID: <5548F965.9070302@dawncrow.de> Date: Tue, 05 May 2015 19:09:57 +0200 From: =?windows-1252?Q?Andr=E9_Hentschel?= User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Will Deacon CC: "linux-arch@vger.kernel.org" , Russell King - ARM Linux , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "gregkh@linuxfoundation.org" , Jonathan Austin , Nathan Lynch , Catalin Marinas Subject: Re: [PATCH] arm64: Preserve the user r/w register tpidr_el0 on context switch and fork in compat mode References: <55464BB2.7030401@dawncrow.de> <20150505105111.GB1550@arm.com> In-Reply-To: <20150505105111.GB1550@arm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1411 Lines: 33 Am 05.05.2015 um 12:51 schrieb Will Deacon: > On Sun, May 03, 2015 at 05:24:18PM +0100, Andr? Hentschel wrote: >> From: Andr? Hentschel >> >> Since commit a4780adeefd042482f624f5e0d577bf9cdcbb760 the user writeable TLS >> register on ARM is preserved per thread. >> >> This patch does it analogous to the ARM patch, but for compat mode on ARM64. >> >> Signed-off-by: Andr? Hentschel >> Cc: Will Deacon >> Cc: Jonathan Austin >> >> --- >> This patch is against Linux 4.1-rc1 (b787f68c36d49bb1d9236f403813641efa74a031) > > Curious, but why do you need this? iirc, we added this for arch/arm/ because > of some windows rt (?) emulation in wine. Is that still the case here and is > anybody actually using that? Yes, Windows ARM binaries are the well known use case, but also the compat mode should do what the arm kernel is doing I?d think and the code wasn't adjusted yet. What i'm curious about is why the main TLS register on arm64 is the user writeable, I'm not an security expert but this looks odd. I could easily provoke a crash by writing to it... CCing Catalin Marinas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/