Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760684AbbEERPw (ORCPT ); Tue, 5 May 2015 13:15:52 -0400 Received: from mail-ig0-f172.google.com ([209.85.213.172]:36717 "EHLO mail-ig0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755832AbbEERPt (ORCPT ); Tue, 5 May 2015 13:15:49 -0400 MIME-Version: 1.0 In-Reply-To: <1430757460-9478-12-git-send-email-rklein@nvidia.com> References: <1430757460-9478-1-git-send-email-rklein@nvidia.com> <1430757460-9478-12-git-send-email-rklein@nvidia.com> Date: Tue, 5 May 2015 10:15:47 -0700 X-Google-Sender-Auth: 2tKpW9OS76fns-dJthv6npRyWgs Message-ID: Subject: Re: [PATCH v4 11/20] clk: tegra: pll: Add code to handle if resets are supported by PLL From: Benson Leung To: Rhyland Klein Cc: Peter De Schrijver , Mike Turquette , Stephen Warren , Stephen Boyd , Thierry Reding , Alexandre Courbot , linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org, "linux-kernel@vger.kernel.org" , Bill Huang Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1256 Lines: 41 On Mon, May 4, 2015 at 9:37 AM, Rhyland Klein wrote: > From: Bill Huang > > If a PLL has a reset_reg specified, properly handle that in the > enable/disable logic paths. > > Signed-off-by: Bill Huang Minor nit to add kerneldoc for params. Otherwise, LGTM. Reviewed-by: Benson Leung > diff --git a/drivers/clk/tegra/clk.h b/drivers/clk/tegra/clk.h > index b63ef31a2d7a..0146c91df635 100644 > --- a/drivers/clk/tegra/clk.h > +++ b/drivers/clk/tegra/clk.h > @@ -217,6 +217,8 @@ struct tegra_clk_pll_params { > u32 lock_enable_bit_idx; > u32 iddq_reg; > u32 iddq_bit_idx; > + u32 reset_reg; > + u32 reset_bit_idx; Kerneldoc for these two. > u32 sdm_din_reg; > u32 sdm_din_mask; > u32 sdm_ctrl_reg; -- Benson Leung Software Engineer, Chrom* OS bleung@chromium.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/