Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761796AbbEERW0 (ORCPT ); Tue, 5 May 2015 13:22:26 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:37452 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755863AbbEERWT (ORCPT ); Tue, 5 May 2015 13:22:19 -0400 MIME-Version: 1.0 In-Reply-To: <1430840557.3035.60.camel@pengutronix.de> References: <1430410844-16062-1-git-send-email-mcoquelin.stm32@gmail.com> <1430410844-16062-6-git-send-email-mcoquelin.stm32@gmail.com> <55433467.2010603@linaro.org> <5544A069.5000808@linaro.org> <5548CEA2.8020807@linaro.org> <1430840557.3035.60.camel@pengutronix.de> Date: Tue, 5 May 2015 19:22:17 +0200 Message-ID: Subject: Re: [PATCH v7 05/15] dt-bindings: Document the STM32 reset bindings From: Maxime Coquelin To: Philipp Zabel , "devicetree@vger.kernel.org" , Rob Herring Cc: Daniel Thompson , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Geert Uytterhoeven , Linus Walleij , Arnd Bergmann , Stefan Agner , Peter Meerwald , Paul Bolle , Peter Hurley , Andy Shevchenko , Chanwoo Choi , Russell King , Daniel Lezcano , Joe Perches , Vladimir Zapolskiy , Jonathan Corbet , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Thomas Gleixner , Greg Kroah-Hartman , Jiri Slaby , Andrew Morton , "David S. Miller" , Mauro Carvalho Chehab , Antti Palosaari , Tejun Heo , Will Deacon , Nikolay Borisov , Rusty Russell , Kees Cook , Michal Marek , "linux-doc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-serial@vger.kernel.org" , Linux-Arch , "linux-api@vger.kernel.org" , Nicolae Rosia , Kamil Lulko , Lee Jones Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1649 Lines: 54 2015-05-05 17:42 GMT+02:00 Philipp Zabel : > Am Dienstag, den 05.05.2015, 17:19 +0200 schrieb Maxime Coquelin: >> >> For example, includes/dt-bindings/mfd/stm32f4-rcc.h would look like: >> >> >> >> #define GPIOA 0 >> >> #define GPIOB 1 >> >> ... >> >> #define LTDC 186 > > That looks a bit fragile. > At least the defines for the indices should be properly namespaced, > check out include/dt-bindings/gpio/tegra-gpio.h for a similar case. Thanks, I will prefix them with the proper namespace, Daniel proposal is fine to me. > >> >> #define STM32F4_RESET(x) (x + 128) >> >> #define STM32F4_CLOCK(x) (x + 384) >> >> >> >> Then, in DT, a reset would be described like this: >> >> >> >> timer2 { >> >> resets = <&rcc STM32F4_RESET(TIM2)>; >> >> }; >> >> >> >> Phillip, Daniel, does that look acceptable to you? >> > >> > >> > Doesn't look unreasonable. >> > >> > I am a little uneasy simply because there are very few similar header files >> > in that directory but I haven't thought of a better idea. >> >> Since this file will be shared by both clock and reset drivers, I >> don't see better option. >> I will implement it in v8 if Philipp agrees. > > Are the device tree maintainers happy with this idiom spreading? > Except for the point above, I think this is acceptable. Ok good. Let's see what DT maintainers thinks about that. Regards, Maxime > > regards > Philipp > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/