Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932960AbbEER0F (ORCPT ); Tue, 5 May 2015 13:26:05 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:60905 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932926AbbEER0B (ORCPT ); Tue, 5 May 2015 13:26:01 -0400 X-IronPort-AV: E=Sophos;i="5.13,373,1427760000"; d="scan'208";a="261916940" Message-ID: <5548FD26.8080906@citrix.com> Date: Tue, 5 May 2015 18:25:58 +0100 From: David Vrabel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: Boris Ostrovsky , , , , CC: , , , Subject: Re: [PATCH v2] hypervisor/x86/xen: Unset X86_BUG_SYSRET_SS_ATTRS on Xen PV guests References: <1430751735-5471-1-git-send-email-boris.ostrovsky@oracle.com> In-Reply-To: <1430751735-5471-1-git-send-email-boris.ostrovsky@oracle.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 760 Lines: 30 On 04/05/15 16:02, Boris Ostrovsky wrote: > > --- a/arch/x86/xen/enlighten.c > +++ b/arch/x86/xen/enlighten.c > @@ -1760,6 +1760,9 @@ static struct notifier_block xen_hvm_cpu_notifier = { > > static void __init xen_hvm_guest_init(void) > { > + if (xen_pv_domain()) > + return; > + I take Andy's point that this looks a little odd, perhaps... static void __init xen_platform_init(void) { if (!xen_pv_domain()) xen_hvm_guest_init(); } Would be a useful follow up? I'll apply as-is though David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/