Message-ID: <5548FE5C.80609@oracle.com>
Date: Tue, 05 May 2015 13:31:08 -0400
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: David Vrabel <david.vrabel@citrix.com>, konrad.wilk@oracle.com,
        hpa@zytor.com, mingo@redhat.com, tglx@linutronix.de
CC: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
        linux@eikelenboom.it, luto@amacapital.net
Subject: Re: [PATCH v2] hypervisor/x86/xen: Unset X86_BUG_SYSRET_SS_ATTRS
 on Xen PV guests
References: <1430751735-5471-1-git-send-email-boris.ostrovsky@oracle.com> <5548FD26.8080906@citrix.com>
In-Reply-To: <5548FD26.8080906@citrix.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 926
Lines: 34

On 05/05/2015 01:25 PM, David Vrabel wrote:
> On 04/05/15 16:02, Boris Ostrovsky wrote:
>> --- a/arch/x86/xen/enlighten.c
>> +++ b/arch/x86/xen/enlighten.c
>> @@ -1760,6 +1760,9 @@ static struct notifier_block xen_hvm_cpu_notifier = {
>>   
>>   static void __init xen_hvm_guest_init(void)
>>   {
>> +	if (xen_pv_domain())
>> +		return;
>> +
> I take Andy's point that this looks a little odd, perhaps...
>
> static void __init xen_platform_init(void)
> {
>      if (!xen_pv_domain())
>          xen_hvm_guest_init();
> }
>
> Would be a useful follow up?
>
> I'll apply as-is though
>


Yes, this would look better. I can respin this if you want to avoid the 
extra patch.

-boris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/