Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965477AbbEERjP (ORCPT ); Tue, 5 May 2015 13:39:15 -0400 Received: from mailsec102.isp.belgacom.be ([195.238.20.98]:60658 "EHLO mailsec102.isp.belgacom.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965325AbbEERjL convert rfc822-to-8bit (ORCPT ); Tue, 5 May 2015 13:39:11 -0400 X-Cloudmark-SP-Filtered: true X-Cloudmark-SP-Result: v=1.1 cv=+BsAzE94k0WpM8AtezFGaEXBVpw1lpSE4R7UN5Nfg4g= c=1 sm=2 a=IkcTkHD0fZMA:10 a=p-nOP-kxAAAA:8 a=tbzgEM1XamiG4p3mAxkA:9 a=QEXdDO2ut3YA:10 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2DUCgDV/0hV/9QU7sNcgwyBL4MdsHMBAQEBAQaZSwKBPEwBAQEBAQGBC0EFg1oBAQEDASNWBQsFBAIYAgIYDgICVwYTEYgTDJNinQeGUY0WAQEBAQYCAR+BIYR2hSKEUjMHgmiBRQWpRIleI2CDFjwxgkUBAQE Date: Tue, 5 May 2015 19:39:11 +0200 (CEST) From: Fabian Frederick Reply-To: Fabian Frederick To: "Rafael J. Wysocki" Cc: "Rafael J. Wysocki" , linux-kernel@vger.kernel.org Message-ID: <580034320.260650.1430847551331.open-xchange@webmail.nmp.proximus.be> In-Reply-To: <2355892.05HhS4M0WH@vostro.rjw.lan> References: <1430582481-31606-1-git-send-email-fabf@skynet.be> <2355892.05HhS4M0WH@vostro.rjw.lan> Subject: Re: [PATCH 1/1 linux-next] PNP: move EXPORT_SYMBOL after functions MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.2.2-Rev27 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1137 Lines: 37 > On 04 May 2015 at 23:30 "Rafael J. Wysocki" wrote: > > > On Saturday, May 02, 2015 06:01:21 PM Fabian Frederick wrote: > > EXPORT macro must be placed directly after functions. > > See Documentation/CodingStyle Chapter 6 > > Well, why is this change an improvement? > > Yes, it makes an old file follow the new(er) Documentation/CodingStyl, > but what exactly is the benefit? > > Mind you, there are more files with EXPORT_SYMBOL(_GPL) at the end. > Are you going to hunt for them now or something? Hi Rafael,                 AFAIK it just brings more readability. I sent you this one while fixing warnings in 2 PNPACPI patches but of course you can ignore it :) Fortunately, I don't plan to send a patch for each EXPORT_SYMBOL(_GPL) "problem" :) Regards, Fabian > > > -- > I speak only for myself. > Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/