Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757370AbbEETaK (ORCPT ); Tue, 5 May 2015 15:30:10 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:51997 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753360AbbEETaH (ORCPT ); Tue, 5 May 2015 15:30:07 -0400 Date: Tue, 5 May 2015 15:30:06 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Ramneek Mehresh cc: Kernel development list , Felipe Balbi , USB list , Subject: Re: [PATCH 2/9][v3]usb:fsl:otg: Add support to add/remove usb host driver In-Reply-To: <1430848716-32157-2-git-send-email-ramneek.mehresh@freescale.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1068 Lines: 34 On Tue, 5 May 2015, Ramneek Mehresh wrote: > Add workqueue to add/remove host driver (outside interrupt context) > upon each id change > > Signed-off-by: Ramneek Mehresh > --- > Changes for v3: > - use overrides for ehci_fsl_overrides > - remove struct ehci_hcd from ehci_fsl > - move ehci_fsl to ehci-fsl.h This patch changes at least three separate things: It adds the workqueue stuff. It replaces ehci_fsl_hc_driver with ehci_fsl_overrides. It adds new fields into the overrides structure. A patch should do only one thing. It certainly shouldn't make three separate, major changes! Also, I'm not going to let you add new fields into the ehci_driver_overrides structure. If you really need to override other routines, copy the approach used by ehci-tegra.c. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/