Message-ID: <1430854949.16357.240.camel@freescale.com>
Subject: Re: [PATCH 1/7] staging: fsl-mc: MC bus IRQ support
From: Scott Wood <scottwood@freescale.com>
To: Rivera Jose-B46482 <German.Rivera@freescale.com>
CC: Dan Carpenter <dan.carpenter@oracle.com>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        "agraf@suse.de" <agraf@suse.de>, "arnd@arndb.de" <arnd@arndb.de>,
        Sharma Bhupesh-B45370 <bhupesh.sharma@freescale.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Yoder Stuart-B08248 <stuart.yoder@freescale.com>,
        Erez Nir-RM30794 <nir.erez@freescale.com>,
        "katz Itai-RM05202" <itai.katz@freescale.com>,
        Hamciuc Bogdan-BHAMCIU1 <bhamciu1@freescale.com>,
        Marginean Alexandru-R89243 <R89243@freescale.com>,
        Schmitt Richard-B43082 <richard.schmitt@freescale.com>
Date: Tue, 5 May 2015 14:42:29 -0500
In-Reply-To: <DM2PR0301MB1309A6F411B54A6A1626E78EFED10@DM2PR0301MB1309.namprd03.prod.outlook.com>
References: <1430242750-17745-1-git-send-email-German.Rivera@freescale.com>
	 <1430242750-17745-2-git-send-email-German.Rivera@freescale.com>
	 <20150430114957.GW14154@mwanda>
	 <DM2PR0301MB1309AA660970101D3882E650FED20@DM2PR0301MB1309.namprd03.prod.outlook.com>
	 <20150505084830.GL16501@mwanda>
	 <DM2PR0301MB1309A6F411B54A6A1626E78EFED10@DM2PR0301MB1309.namprd03.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2015 19:42:35.5962
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1482
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1635
Lines: 39

On Tue, 2015-05-05 at 11:08 -0500, Rivera Jose-B46482 wrote:
> > > > to read what "goto error;" does.  The error handling here calls
> > > > devm_kfree() which is not needed...  devm_ functions automatically
> > > > clean up after themselves.  This seems a pattern throughout.  Do a
> > > > search for
> > > > devm_free() and see which ones are really needed or not.
> > > >
> > > I know that memory allocated with devm_kzalloc() is freed at the end
> > > of the lifetime of the device it is attached to. However, in error
> > > paths, why wait until the device is destroyed? Why not free the memory
> > > earlier so that it can be used for other purposes?
> > 
> Why then do the devm_kfree() function exist?
> 
> I will not remove the devm_free() calls unless the upstream maintainer
> requires me to do so.

The whole point of devm is to simplify (often poorly tested) error
paths.  You're trying to optimize the error path instead of simplify it,
which doesn't make sense.

devm_kfree() is for the uncommon case when you want to free the memory
in a situation where the device isn't being unbound any time soon, but
you still want the memory to be handled by devm for some reason.

Most users of devm_kzalloc() do not use devm_kfree():
scott@snotra:~/fsl/git/linux/upstream$ git grep devm_kzalloc|wc -l
2750
scott@snotra:~/fsl/git/linux/upstream$ git grep devm_kfree|wc -l
118

-Scott


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/