Message-ID: <1430855801.16357.251.camel@freescale.com>
Subject: Re: [PATCH 1/7] staging: fsl-mc: MC bus IRQ support
From: Scott Wood <scottwood@freescale.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
CC: Jose Rivera <German.Rivera@freescale.com>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        Stuart Yoder <stuart.yoder@freescale.com>,
        "bhamciu1@freescale.com" <bhamciu1@freescale.com>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "bhupesh.sharma@freescale.com" <bhupesh.sharma@freescale.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "agraf@suse.de" <agraf@suse.de>,
        "nir.erez@freescale.com" <nir.erez@freescale.com>,
        "itai.katz@freescale.com" <itai.katz@freescale.com>,
        "R89243@freescale.com" <R89243@freescale.com>,
        Richard Schmitt <richard.schmitt@freescale.com>
Date: Tue, 5 May 2015 14:56:41 -0500
In-Reply-To: <20150505164011.GT14154@mwanda>
References: <1430242750-17745-1-git-send-email-German.Rivera@freescale.com>
	 <1430242750-17745-2-git-send-email-German.Rivera@freescale.com>
	 <20150430114957.GW14154@mwanda>
	 <DM2PR0301MB1309AA660970101D3882E650FED20@DM2PR0301MB1309.namprd03.prod.outlook.com>
	 <20150505084830.GL16501@mwanda>
	 <DM2PR0301MB1309A6F411B54A6A1626E78EFED10@DM2PR0301MB1309.namprd03.prod.outlook.com>
	 <20150505164011.GT14154@mwanda>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2015 19:56:55.8163
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB1488
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2309
Lines: 53

On Tue, 2015-05-05 at 19:40 +0300, Dan Carpenter wrote:
> On Tue, May 05, 2015 at 04:08:49PM +0000, Jose Rivera wrote:
> > > Subject: Re: [PATCH 1/7] staging: fsl-mc: MC bus IRQ support
> > > 
> > > On Mon, May 04, 2015 at 10:09:08PM +0000, Jose Rivera wrote:
> > > > > > +		WARN_ON((int16_t)irq_count < 0);
> > > > >
> > > > > This code is doing "WARN_ON(test_bit(15, (unsigned long
> > > *)&irq_count));".
> > > > > That seems like nonsense.  Anyway, just delete the WARN_ON().
> > > > >
> > > > I disagree. This WARN_ON is checking that irq_count is in the expected
> > > > range (it fits in int16_t as a positive number). The
> > > > dprc_scan_objects() function expects irq_count to be of type "unsigned
> > > > int" (which is 32-bit unsigned)
> > > >
> > > 
> > > You're not allowed to disagree because it's a testable thing and not an
> > > opinion about style or something.  :P  What you want is:
> > > 
> > > 	WARN_ON(irq_count > SHRT_MAX);
> > > 
> > I see your point now. The check "(int16_t)irq_count < 0)" will not be able
> > to catch 0x10000 > 0x7fff, but "irq_count > SHRT_MAX) will. So I'll
> > make the suggested change, but I would prefer to use S16_MAX rather than 
> > SHRT_MAX.
> > 
> 
> Huh?  I didn't even know about the S16_MAX definition.  There are
> literally no users of it in the kernel.  It's not very fair because
> there are few users of SHRT_MAX.  But there are literally no users of
> S32_MAX in the kernel and 358 users of INT_MAX.
> 
> Don't insist that you must be special and different from everyone else.

There are some users of U16_MAX, U32_MAX, and U64_MAX.  Why use a limit
for a different type than is being used?  Why have s16/s32 at all if
you're going to conflate it with short/int elsewhere?

That said, I don't see where this code is actually using s16 (or
int16_t) for irq_count except in these weird error checks.  German, why
do you need to check against 0x7fff (whatever you call it) at all?
Won't comparing to a promoted-to-unsigned-int .max_count (as you do
immediately after the WARN_ON) suffice?

-Scott


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/