Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031075AbbEEUM4 (ORCPT ); Tue, 5 May 2015 16:12:56 -0400 Received: from mga01.intel.com ([192.55.52.88]:35011 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757017AbbEEUMz (ORCPT ); Tue, 5 May 2015 16:12:55 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,374,1427785200"; d="scan'208";a="724199657" Message-ID: <55492446.4050304@linux.intel.com> Date: Tue, 05 May 2015 13:12:54 -0700 From: Dave Hansen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Ingo Molnar , linux-kernel@vger.kernel.org CC: Andy Lutomirski , Borislav Petkov , Fenghua Yu , "H. Peter Anvin" , Linus Torvalds , Oleg Nesterov , Thomas Gleixner Subject: Re: [PATCH 201/208] x86/fpu: Clean up xstate feature reservation References: <1430848712-28064-1-git-send-email-mingo@kernel.org> <1430848712-28064-41-git-send-email-mingo@kernel.org> In-Reply-To: <1430848712-28064-41-git-send-email-mingo@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 819 Lines: 20 On 05/05/2015 10:58 AM, Ingo Molnar wrote: > struct xregs_state { > struct fxregs_state i387; > struct xstate_header header; > - struct ymmh_struct ymmh; > - struct lwp_struct lwp; > - struct bndreg bndreg[4]; > - struct bndcsr bndcsr; > - /* New processor state extensions will go here. */ > + u8 __reserved[XSTATE_RESERVE]; > } __attribute__ ((packed, aligned (64))); Just to reiterate. The size of 'XSTATE_RESERVE' is completely unknown at compile time. It's wrong in the existing kernel, but we should fix it up instead of mucking with it like this. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/