Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031234AbbEEU2o (ORCPT ); Tue, 5 May 2015 16:28:44 -0400 Received: from mga01.intel.com ([192.55.52.88]:64693 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757540AbbEEU2l (ORCPT ); Tue, 5 May 2015 16:28:41 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,374,1427785200"; d="scan'208";a="489756207" From: "Luck, Tony" To: Aravind Gopalakrishnan , Borislav Petkov CC: "tglx@linutronix.de" , "mingo@redhat.com" , "hpa@zytor.com" , "jiang.liu@linux.intel.com" , "yinghai@kernel.org" , "x86@kernel.org" , "dvlasenk@redhat.com" , "JBeulich@suse.com" , "slaoub@gmail.com" , "luto@amacapital.net" , "dave.hansen@linux.intel.com" , "oleg@redhat.com" , "rostedt@goodmis.org" , "rusty@rustcorp.com.au" , "prarit@redhat.com" , "linux@rasmusvillemoes.dk" , "jroedel@suse.de" , "andriy.shevchenko@linux.intel.com" , "macro@linux-mips.org" , "wangnan0@huawei.com" , "linux-kernel@vger.kernel.org" , "linux-edac@vger.kernel.org" , Robert Richter Subject: RE: [PATCH 2/4] x86/mce/amd: Introduce deferred error interrupt handler Thread-Topic: [PATCH 2/4] x86/mce/amd: Introduce deferred error interrupt handler Thread-Index: AQHQg381KLs4Z2UXuUeJebHJytQyNZ1qc6AAgAH5DACAAATCAIAAFr4AgAAbgoCAAZAwgP//qG6w Date: Tue, 5 May 2015 20:28:29 +0000 Message-ID: <3908561D78D1C84285E8C5FCA982C28F32A75C4C@ORSMSX114.amr.corp.intel.com> References: <1430405365-4473-1-git-send-email-Aravind.Gopalakrishnan@amd.com> <1430405365-4473-3-git-send-email-Aravind.Gopalakrishnan@amd.com> <20150503092212.GC18048@pd.tnic> <5547906E.3060701@amd.com> <20150504154652.GF3829@pd.tnic> <5547A780.8080800@amd.com> <20150504184643.GH3829@pd.tnic> <55490E47.7040107@amd.com> In-Reply-To: <55490E47.7040107@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.140] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t45KSnh6006723 Content-Length: 393 Lines: 9 Should you check whether the address is valid before blindly reading the register? > m.bank = bank; if (m.status & MCI_STATUS_ADDRV) rdmsrl(MSR_IA32_MCx_ADDR(bank), m.addr); > mce_log(&m); -Tony ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?