Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031288AbbEEUeM (ORCPT ); Tue, 5 May 2015 16:34:12 -0400 Received: from mail-bn1on0130.outbound.protection.outlook.com ([157.56.110.130]:41032 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757565AbbEEUeG (ORCPT ); Tue, 5 May 2015 16:34:06 -0400 Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=amd.com; alien8.de; dkim=none (message not signed) header.d=none; X-WSS-ID: 0NNW94K-07-3F4-02 X-M-MSG: Message-ID: <5549292B.70304@amd.com> Date: Tue, 5 May 2015 15:33:47 -0500 From: Aravind Gopalakrishnan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: "Luck, Tony" , Borislav Petkov CC: "tglx@linutronix.de" , "mingo@redhat.com" , "hpa@zytor.com" , "jiang.liu@linux.intel.com" , "yinghai@kernel.org" , "x86@kernel.org" , "dvlasenk@redhat.com" , "JBeulich@suse.com" , "slaoub@gmail.com" , "luto@amacapital.net" , "dave.hansen@linux.intel.com" , "oleg@redhat.com" , "rostedt@goodmis.org" , "rusty@rustcorp.com.au" , "prarit@redhat.com" , "linux@rasmusvillemoes.dk" , "jroedel@suse.de" , "andriy.shevchenko@linux.intel.com" , "macro@linux-mips.org" , "wangnan0@huawei.com" , "linux-kernel@vger.kernel.org" , "linux-edac@vger.kernel.org" , Robert Richter Subject: Re: [PATCH 2/4] x86/mce/amd: Introduce deferred error interrupt handler References: <1430405365-4473-1-git-send-email-Aravind.Gopalakrishnan@amd.com> <1430405365-4473-3-git-send-email-Aravind.Gopalakrishnan@amd.com> <20150503092212.GC18048@pd.tnic> <5547906E.3060701@amd.com> <20150504154652.GF3829@pd.tnic> <5547A780.8080800@amd.com> <20150504184643.GH3829@pd.tnic> <55490E47.7040107@amd.com> <3908561D78D1C84285E8C5FCA982C28F32A75C4C@ORSMSX114.amr.corp.intel.com> In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F32A75C4C@ORSMSX114.amr.corp.intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.221;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(428002)(164054003)(189002)(51704005)(377454003)(24454002)(479174004)(199003)(76176999)(36756003)(54356999)(46102003)(86362001)(105586002)(64126003)(33656002)(77096005)(106466001)(4001350100001)(2950100001)(5001770100001)(101416001)(83506001)(47776003)(77156002)(62966003)(50986999)(87936001)(93886004)(65816999)(50466002)(23676002)(92566002)(65956001);DIR:OUT;SFP:1102;SCL:1;SRVR:CO1PR02MB079;H:atltwp01.amd.com;FPR:;SPF:None;MLV:sfv;MX:1;A:1;LANG:en; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CO1PR02MB079;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CO1PR02MB032; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:CO1PR02MB079;BCL:0;PCL:0;RULEID:;SRVR:CO1PR02MB079; X-Forefront-PRVS: 0567A15835 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2015 20:33:59.3797 (UTC) X-MS-Exchange-CrossTenant-Id: fde4dada-be84-483f-92cc-e026cbee8e96 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fde4dada-be84-483f-92cc-e026cbee8e96;Ip=[165.204.84.221];Helo=[atltwp01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR02MB079 X-OriginatorOrg: amd4.onmicrosoft.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 595 Lines: 18 On 5/5/2015 3:28 PM, Luck, Tony wrote: > Should you check whether the address is valid before blindly reading the register? > >> m.bank = bank; > if (m.status & MCI_STATUS_ADDRV) > rdmsrl(MSR_IA32_MCx_ADDR(bank), m.addr); >> mce_log(&m); Yes, missed that when I sent the snippet. Fixed it:) Thanks, -Aravind. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/