Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933195AbbEEWBW (ORCPT ); Tue, 5 May 2015 18:01:22 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:28635 "EHLO imgpgp01.kl.imgtec.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932110AbbEEWBT (ORCPT ); Tue, 5 May 2015 18:01:19 -0400 X-PGP-Universal: processed; by imgpgp01.kl.imgtec.org on Tue, 05 May 2015 23:01:18 +0100 Date: Tue, 5 May 2015 23:01:17 +0100 From: James Hogan To: Andrew Bresticker CC: Ralf Baechle , Kishon Vijay Abraham I , , , , James Hartley , Damien Horsley , Rob Herring , Pawel Moll , Mark Rutland , "Ian Campbell" , Kumar Gala Subject: Re: [PATCH V2 1/3] phy: Add binding document for Pistachio USB2.0 PHY Message-ID: <20150505220116.GE17687@jhogan-linux.le.imgtec.org> References: <1428444258-25852-1-git-send-email-abrestic@chromium.org> <1428444258-25852-2-git-send-email-abrestic@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="VdOwlNaOFKGAtAAV" Content-Disposition: inline In-Reply-To: <1428444258-25852-2-git-send-email-abrestic@chromium.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [192.168.154.110] X-ESG-ENCRYPT-TAG: b93fcccb Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4493 Lines: 130 --VdOwlNaOFKGAtAAV Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Andrew, On Tue, Apr 07, 2015 at 03:04:16PM -0700, Andrew Bresticker wrote: > Add a binding document for the USB2.0 PHY found on the IMG Pistachio SoC. >=20 > Signed-off-by: Andrew Bresticker > Cc: Rob Herring > Cc: Pawel Moll > Cc: Mark Rutland > Cc: Ian Campbell > Cc: Kumar Gala > --- > No changes from v1. > --- > .../devicetree/bindings/phy/pistachio-usb-phy.txt | 29 ++++++++++++++++= ++++++ > include/dt-bindings/phy/phy-pistachio-usb.h | 16 ++++++++++++ > 2 files changed, 45 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/pistachio-usb-p= hy.txt > create mode 100644 include/dt-bindings/phy/phy-pistachio-usb.h >=20 > diff --git a/Documentation/devicetree/bindings/phy/pistachio-usb-phy.txt = b/Documentation/devicetree/bindings/phy/pistachio-usb-phy.txt > new file mode 100644 > index 0000000..afbc7e2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/pistachio-usb-phy.txt > @@ -0,0 +1,29 @@ > +IMG Pistachio USB PHY > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > + > +Required properties: > +-------------------- > + - compatible: Must be "img,pistachio-usb-phy". > + - #phy-cells: Must be 0. See ./phy-bindings.txt for details. > + - clocks: Must contain an entry for each entry in clock-names. > + See ../clock/clock-bindings.txt for details. > + - clock-names: Must include "usb_phy". > + - img,cr-top: Must constain a phandle to the CR_TOP syscon node. > + - img,refclk: Indicates the reference clock source for the USB PHY. > + See for a list of valid values. Possibly dumb question: why isn't the reference clock source specified in the normal ways like the "usb_phy" clock is? Does the value required here depend on what usb_phy clock gets muxed =66rom or something? Cheers James > + > +Optional properties: > +-------------------- > + - phy-supply: USB VBUS supply. Must supply 5.0V. > + > +Example: > +-------- > +usb_phy: usb-phy { > + compatible =3D "img,pistachio-usb-phy"; > + clocks =3D <&clk_core CLK_USB_PHY>; > + clock-names =3D "usb_phy"; > + phy-supply =3D <&usb_vbus>; > + img,refclk =3D ; > + img,cr-top =3D <&cr_top>; > + #phy-cells =3D <0>; > +}; > diff --git a/include/dt-bindings/phy/phy-pistachio-usb.h b/include/dt-bin= dings/phy/phy-pistachio-usb.h > new file mode 100644 > index 0000000..d1877aa > --- /dev/null > +++ b/include/dt-bindings/phy/phy-pistachio-usb.h > @@ -0,0 +1,16 @@ > +/* > + * Copyright (C) 2015 Google, Inc. > + * > + * This program is free software; you can redistribute it and/or modify = it > + * under the terms and conditions of the GNU General Public License, > + * version 2, as published by the Free Software Foundation. > + */ > + > +#ifndef _DT_BINDINGS_PHY_PISTACHIO > +#define _DT_BINDINGS_PHY_PISTACHIO > + > +#define REFCLK_XO_CRYSTAL 0x0 > +#define REFCLK_X0_EXT_CLK 0x1 > +#define REFCLK_CLK_CORE 0x2 > + > +#endif /* _DT_BINDINGS_PHY_PISTACHIO */ > --=20 > 2.2.0.rc0.207.ga3a616c >=20 >=20 --VdOwlNaOFKGAtAAV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVST2sAAoJEGwLaZPeOHZ6h3EQAIWL5SPjeM4XQVqS8syp5m45 9pAnlu3nfqJorWzkH5JMfe8bSRRoQ+HKCzGVZ3YoqUKT9ZeTM3cvBCu0OaK/dfWZ +HFLDwukaibdOyIfvfk7527uOUwtwTnbX3bett6ECeXS0Ar3AxI54ibln936n9sW 3XbSBY1YId+EE06uvuVFgib+mGRJQU9o8FqjhIGL/507CHsXfEzcaiT9rY/fs5FA 3pAaoTNL7SODk9fnW+gXFt2gSC40yZ89qoIjwSjkjkYeojtX4+ZiloxlrJddK2sk 2VtYLuXxK+4lnS4EB1X2DXyEe1utpy5JEo5vGsBXV5SYFbmDemxMIpKD7Llx/E9p P7hybOPpAr5yDx4xzQqMbS5wYf8IzlsJVLMYj9wyqSPPHzz+78YpF9Zi0kKrYsL5 lRE3ejHYjBA8x3zQcihXf4Z0vD0mTT+l+VL7IOPVnQl78KSVUNNNU7DVrd7J+ewF Gnx4p1ZCvKKYGYNXH2wMubMs8p+pM+7DU+WEowCYWTRi1iaSVoonZ90XWV1oHiNJ VQ+v/Y5jdHgsfNZ/sGRWHhxl/dW3kwyYAKlEfu1juCnFrBw1/t1Ap2HrpgDaOJwJ otT/kWJHyE+f4iDtnD6Q52QdgC4+8Fov4kNpputOijQIuowV27jopYuUa0xU29+i 5nj2MeKORszfDYANiOKb =lJGl -----END PGP SIGNATURE----- --VdOwlNaOFKGAtAAV-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/