Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933702AbbEEWQb (ORCPT ); Tue, 5 May 2015 18:16:31 -0400 Received: from mail-qg0-f42.google.com ([209.85.192.42]:34643 "EHLO mail-qg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933626AbbEEWQY (ORCPT ); Tue, 5 May 2015 18:16:24 -0400 MIME-Version: 1.0 In-Reply-To: <20150505220116.GE17687@jhogan-linux.le.imgtec.org> References: <1428444258-25852-1-git-send-email-abrestic@chromium.org> <1428444258-25852-2-git-send-email-abrestic@chromium.org> <20150505220116.GE17687@jhogan-linux.le.imgtec.org> Date: Tue, 5 May 2015 15:16:23 -0700 X-Google-Sender-Auth: pF4Q6c-14YsOGpRPK7XkLhjP6cA Message-ID: Subject: Re: [PATCH V2 1/3] phy: Add binding document for Pistachio USB2.0 PHY From: Andrew Bresticker To: James Hogan Cc: Ralf Baechle , Kishon Vijay Abraham I , "devicetree@vger.kernel.org" , Linux-MIPS , "linux-kernel@vger.kernel.org" , James Hartley , Damien Horsley , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2472 Lines: 60 Hi James, On Tue, May 5, 2015 at 3:01 PM, James Hogan wrote: > Hi Andrew, > > On Tue, Apr 07, 2015 at 03:04:16PM -0700, Andrew Bresticker wrote: >> Add a binding document for the USB2.0 PHY found on the IMG Pistachio SoC. >> >> Signed-off-by: Andrew Bresticker >> Cc: Rob Herring >> Cc: Pawel Moll >> Cc: Mark Rutland >> Cc: Ian Campbell >> Cc: Kumar Gala >> --- >> No changes from v1. >> --- >> .../devicetree/bindings/phy/pistachio-usb-phy.txt | 29 ++++++++++++++++++++++ >> include/dt-bindings/phy/phy-pistachio-usb.h | 16 ++++++++++++ >> 2 files changed, 45 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/phy/pistachio-usb-phy.txt >> create mode 100644 include/dt-bindings/phy/phy-pistachio-usb.h >> >> diff --git a/Documentation/devicetree/bindings/phy/pistachio-usb-phy.txt b/Documentation/devicetree/bindings/phy/pistachio-usb-phy.txt >> new file mode 100644 >> index 0000000..afbc7e2 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/phy/pistachio-usb-phy.txt >> @@ -0,0 +1,29 @@ >> +IMG Pistachio USB PHY >> +===================== >> + >> +Required properties: >> +-------------------- >> + - compatible: Must be "img,pistachio-usb-phy". >> + - #phy-cells: Must be 0. See ./phy-bindings.txt for details. >> + - clocks: Must contain an entry for each entry in clock-names. >> + See ../clock/clock-bindings.txt for details. >> + - clock-names: Must include "usb_phy". >> + - img,cr-top: Must constain a phandle to the CR_TOP syscon node. >> + - img,refclk: Indicates the reference clock source for the USB PHY. >> + See for a list of valid values. > > Possibly dumb question: why isn't the reference clock source specified > in the normal ways like the "usb_phy" clock is? > > Does the value required here depend on what usb_phy clock gets muxed > from or something? Right, the value indicates what clock "usb_phy" is: whether it comes from the core clock controller, the XO crystal, or is some external clock. It's a mux internal to the PHY. Thanks, Andrew -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/