Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965700AbbEEWoh (ORCPT ); Tue, 5 May 2015 18:44:37 -0400 Received: from 66.63.173.11.static.quadranet.com ([66.63.173.11]:42244 "EHLO q1.ich-9.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1754775AbbEEWod (ORCPT ); Tue, 5 May 2015 18:44:33 -0400 Message-ID: <1430865868.5842.8.camel@memnix.com> Subject: Re: [PATCH] MODSIGN: Change default key details [ver #2] From: Abelardo Ricart III To: David Howells Cc: Linus Torvalds , Michal Marek , Greg Kroah-Hartman , LSM List , Rusty Russell , keyrings@linux-nfs.org, James Morris , Sedat Dilek , Linux Kernel Mailing List Date: Tue, 05 May 2015 18:44:28 -0400 In-Reply-To: <16633.1430836479@warthog.procyon.org.uk> References: <1430775634.5845.30.camel@memnix.com> <1430516505-4812-1-git-send-email-aricart@memnix.com> <1430559977.5803.12.camel@memnix.com> <1430714551.5800.93.camel@memnix.com> <16633.1430836479@warthog.procyon.org.uk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - q1.ich-9.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - memnix.com X-Get-Message-Sender-Via: q1.ich-9.com: authenticated_id: aricart@memnix.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1160 Lines: 28 On Tue, 2015-05-05 at 15:34 +0100, David Howells wrote: > Abelardo Ricart III wrote: > > > Here's a (barely tested) patch to show what I mean with the config option. > > The > > default case is to always generate a new key at build > > (MODULE_SIG_BUILDGEN=y) > > and fallback on generating keys during build only if one doesn't exist > > (MODULE_SIG_BUILDGEN=n). > > Does it cope with randconfig? > > David Well it would only depend on MODULE_SIG, and switching it on and off again would do exactly what it says it's going to do: either regenerate the signing keys every time, or don't if they already exist. I would have to actually change the logic slightly so it works strictly as intended though. So no, this isn't merge-able at all. I was more wondering if implementing something to this effect would be okay, so we can strictly define the behavior at build time (no surprises). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/