Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755867AbbEFBqV (ORCPT ); Tue, 5 May 2015 21:46:21 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.231]:59048 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752206AbbEFBqS (ORCPT ); Tue, 5 May 2015 21:46:18 -0400 Date: Tue, 5 May 2015 21:46:19 -0400 From: Steven Rostedt To: Badhri Jagan Sridharan Cc: Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH] tracing: Adds handler name to irq_handler_entry Message-ID: <20150505214619.14a60669@grimm.local.home> In-Reply-To: <1430873218-3142-1-git-send-email-Badhri@google.com> References: <1430873218-3142-1-git-send-email-Badhri@google.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-RR-Connecting-IP: 107.14.168.118:25 X-Cloudmark-Score: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1409 Lines: 48 On Tue, 5 May 2015 17:46:58 -0700 Badhri Jagan Sridharan wrote: > This patch includes the ISR function name to > irq_handler_entry trace point. > > Signed-off-by: Badhri Jagan Sridharan > --- > include/trace/events/irq.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/include/trace/events/irq.h b/include/trace/events/irq.h > index ff8f6c0..9994ba4 100644 > --- a/include/trace/events/irq.h > +++ b/include/trace/events/irq.h > @@ -58,14 +58,17 @@ TRACE_EVENT(irq_handler_entry, > TP_STRUCT__entry( > __field( int, irq ) > __string( name, action->name ) > + __field(void*, handler) Please follow the format that the other fields have. This isn't a function call to use the "checkpatch" version of indentation. __field( void *, handler ) -- Steve > ), > > TP_fast_assign( > __entry->irq = irq; > __assign_str(name, action->name); > + __entry->handler = action->handler; > ), > > - TP_printk("irq=%d name=%s", __entry->irq, __get_str(name)) > + TP_printk("irq=%d name=%s handler=%pf", > + __entry->irq, __get_str(name), __entry->handler) > ); > > /** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/