Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756109AbbEFCAq (ORCPT ); Tue, 5 May 2015 22:00:46 -0400 Received: from mail-vn0-f50.google.com ([209.85.216.50]:34014 "EHLO mail-vn0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750925AbbEFCAo (ORCPT ); Tue, 5 May 2015 22:00:44 -0400 MIME-Version: 1.0 In-Reply-To: <1430778649-28126-5-git-send-email-linux@roeck-us.net> References: <1430778649-28126-1-git-send-email-linux@roeck-us.net> <1430778649-28126-5-git-send-email-linux@roeck-us.net> Date: Wed, 6 May 2015 10:00:43 +0800 Message-ID: Subject: Re: [PATCH resend 4/5] score: Fix exception handler label From: Lennox Wu To: Guenter Roeck Cc: open list , Geert Uytterhoeven , Quentin Casasnovas , Chen Liqin Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1556 Lines: 51 Hi Roeck, You are right! I will push the patch. Thank you. Acked-by: Lennox Wu 2015-05-05 6:30 GMT+08:00 Guenter Roeck : > The latest version of modinfo fails to compile score architecture > targets with the following error. > > FATAL: The relocation at __ex_table+0x634 references > section "__ex_table" which is not executable, IOW > the kernel will fault if it ever tries to > jump to it. Something is seriously wrong > and should be fixed. > > The probem is caused by a bad label in an __ex_table entry. > > Cc: Quentin Casasnovas > Signed-off-by: Guenter Roeck > --- > Please consider pushing this patch into mainline, or provide feedback > on how to improve it to be acceptable. > > arch/score/lib/string.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/score/lib/string.S b/arch/score/lib/string.S > index 00b7d3a2fc60..16efa3ad037f 100644 > --- a/arch/score/lib/string.S > +++ b/arch/score/lib/string.S > @@ -175,10 +175,10 @@ ENTRY(__clear_user) > br r3 > > .section .fixup, "ax" > +99: > br r3 > .previous > .section __ex_table, "a" > .align 2 > -99: > .word 0b, 99b > .previous > -- > 2.1.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/