Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755013AbbEFCiE (ORCPT ); Tue, 5 May 2015 22:38:04 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:10217 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751175AbbEFCiB (ORCPT ); Tue, 5 May 2015 22:38:01 -0400 Message-ID: <55497E3F.5090404@huawei.com> Date: Wed, 6 May 2015 10:36:47 +0800 From: Wang Nan User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: Masami Hiramatsu , , , , , , CC: , , , Subject: Re: [RFC PATCH 21/22] perf bpf: probe at kprobe points. References: <1430391165-30267-1-git-send-email-wangnan0@huawei.com> <1430391165-30267-22-git-send-email-wangnan0@huawei.com> <5548F106.3010902@hitachi.com> In-Reply-To: <5548F106.3010902@hitachi.com> Content-Type: text/plain; charset="ISO-2022-JP" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.69.129] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1693 Lines: 60 On 2015/5/6 0:34, Masami Hiramatsu wrote: > At least we need a description what this patch does... what will be > done with this patch, and what the user will see and what/how they can do. > > Thank you, > Sorry. I manually checked patch commit message after 'git format-patch' but forgot this one. I'll fix it in the next version. What this patch do is simply calls 'add_perf_probe_events' (originally used for perf probe) to create kprobe events. Previous patch has puts all events into a uniform array. > On 2015/04/30 19:52, Wang Nan wrote: >> --- >> tools/perf/util/bpf-loader.c | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> >> diff --git a/tools/perf/util/bpf-loader.c b/tools/perf/util/bpf-loader.c >> index 208f5e8..186a3d0 100644 >> --- a/tools/perf/util/bpf-loader.c >> +++ b/tools/perf/util/bpf-loader.c >> @@ -952,8 +952,26 @@ out: >> return -1; >> } >> >> +static int bpf_probe(void) >> +{ >> + int err = add_perf_probe_events(params.event_array, >> + params.nr_events, >> + MAX_PROBES, 0); >> + /* add_perf_probe_events return negative when fail */ >> + if (err < 0) >> + pr_err("bpf probe: failed to probe events\n"); >> + >> + return err < 0 ? err : 0; >> +} >> + >> int bpf__run(void) >> { >> + int err; >> + >> + pr_debug("bpf: probing\n"); >> + if ((err = bpf_probe())) >> + return err; >> + >> pr_info("BPF is running. Use Ctrl-c to stop.\n"); >> while(1) >> sleep(1); >> > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/