Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756023AbbEFCoA (ORCPT ); Tue, 5 May 2015 22:44:00 -0400 Received: from mail-ig0-f173.google.com ([209.85.213.173]:34994 "EHLO mail-ig0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751234AbbEFCn7 (ORCPT ); Tue, 5 May 2015 22:43:59 -0400 Message-ID: <55497FED.6040805@google.com> Date: Tue, 05 May 2015 19:43:57 -0700 From: Badhri Jagan Sridharan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Steven Rostedt , Ingo Molnar , Thomas Gleixner , John Stultz CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] tracing: timer: Add deferrable flag to timer_start References: <1430879527-31114-1-git-send-email-Badhri@google.com> In-Reply-To: <1430879527-31114-1-git-send-email-Badhri@google.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2741 Lines: 81 Please ignore this version... Found another inconsistency in indent. Submitting another patch. On 05/05/2015 07:32 PM, Badhri Jagan Sridharan wrote: > The timer_start event now shows whether the timer is > deferrable in case of a low-res timer. The debug_activate > function now includes deferrable flag while calling > trace_timer_start event. > > Signed-off-by: Badhri Jagan Sridharan > --- > Changelog since v1: > - fixed indentation > - moved deferrable flag checking to tracing code > > include/trace/events/timer.h | 14 +++++++++----- > kernel/time/timer.c | 3 ++- > 2 files changed, 11 insertions(+), 6 deletions(-) > > diff --git a/include/trace/events/timer.h b/include/trace/events/timer.h > index 68c2c20..e69bb03 100644 > --- a/include/trace/events/timer.h > +++ b/include/trace/events/timer.h > @@ -43,15 +43,17 @@ DEFINE_EVENT(timer_class, timer_init, > */ > TRACE_EVENT(timer_start, > > - TP_PROTO(struct timer_list *timer, unsigned long expires), > + TP_PROTO(struct timer_list *timer, > + unsigned long expires, char deferrable), > > - TP_ARGS(timer, expires), > + TP_ARGS(timer, expires, deferrable), > > TP_STRUCT__entry( > __field( void *, timer ) > __field( void *, function ) > __field( unsigned long, expires ) > __field( unsigned long, now ) > + __field( char, deferrable ) > ), > > TP_fast_assign( > @@ -59,11 +61,13 @@ TRACE_EVENT(timer_start, > __entry->function = timer->function; > __entry->expires = expires; > __entry->now = jiffies; > + __entry->deferrable = deferrable; > ), > > - TP_printk("timer=%p function=%pf expires=%lu [timeout=%ld]", > - __entry->timer, __entry->function, __entry->expires, > - (long)__entry->expires - __entry->now) > + TP_printk("timer=%p function=%pf expires=%lu [timeout=%ld] defer=%c", > + __entry->timer, __entry->function, __entry->expires, > + (long)__entry->expires - __entry->now, > + __entry->deferrable > 0 ? 'y':'n') > ); > > /** > diff --git a/kernel/time/timer.c b/kernel/time/timer.c > index 2ece3aa..e5588da 100644 > --- a/kernel/time/timer.c > +++ b/kernel/time/timer.c > @@ -648,7 +648,8 @@ static inline void > debug_activate(struct timer_list *timer, unsigned long expires) > { > debug_timer_activate(timer); > - trace_timer_start(timer, expires); > + trace_timer_start(timer, expires, > + tbase_get_deferrable(timer->base)); > } > > static inline void debug_deactivate(struct timer_list *timer) > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/