Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753438AbbEFCzm (ORCPT ); Tue, 5 May 2015 22:55:42 -0400 Received: from cantor2.suse.de ([195.135.220.15]:49460 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753182AbbEFCzh (ORCPT ); Tue, 5 May 2015 22:55:37 -0400 Date: Wed, 6 May 2015 12:55:28 +1000 From: NeilBrown To: Al Viro Cc: Linus Torvalds , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 51/79] namei: remove restrictions on nesting depth Message-ID: <20150506125528.0be6d30e@notabene.brown> In-Reply-To: <1430803373-4948-51-git-send-email-viro@ZenIV.linux.org.uk> References: <20150505052205.GS889@ZenIV.linux.org.uk> <1430803373-4948-51-git-send-email-viro@ZenIV.linux.org.uk> X-Mailer: Claws Mail 3.10.1-162-g4d0ed6 (GTK+ 2.24.25; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/WNCQMIJbJYzQj77bz+/zabs"; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1971 Lines: 58 --Sig_/WNCQMIJbJYzQj77bz+/zabs Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Tue, 5 May 2015 06:22:25 +0100 Al Viro wrote: > From: Al Viro >=20 > The only restriction is that on the total amount of symlinks > crossed; how they are nested does not matter >=20 > Signed-off-by: Al Viro > --- > - if (unlikely(current->total_link_count >=3D 40)) { > + if (unlikely(current->total_link_count >=3D MAXSYMLINKS)) { There is still a literal '40' in follow_automount. current->total_link_count++; if (current->total_link_count >=3D 40) return -ELOOP; should that become MAXSYMLINKS too? Thanks, NeilBrown --Sig_/WNCQMIJbJYzQj77bz+/zabs Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIVAwUBVUmCoDnsnt1WYoG5AQKmSw//Wh3Nh4qyjzyB5mhQd5iGTmVEU2NWEzFc WQZLEVT7GEXfNI0JcDUKoyWJ2deiGsaG9ciwl5CpslNH0MT0Ng6tqZEsGwsOGmhk rnnnqju9VL0o0IF+9Ec6U+JKqaPfLzUQKQuogL0UNJc4hipVXLQyUdF+Tj5Ikh1G Wnl+dkvoBKoApCOm/GIUvN9UD3dzgApZk4F77brDpqhexz0qRCMIRIvM7bi0Xl7l CxOkplugrQdbfL3ooaFHD/oFjwgci3Q/6WeFxGO/2uPz8QZQmb1K7/VUjQnjBkJs p5pxac8Jk3Xg3U3ZbXb1fIWh8PuY97PU1opEIdrqTSibHuABfnFttNoCbSxbsUJu luGcqFUxjvzpCUBI837ZzhN3HVX0O2yy+RXeCIBkcMCTB/JfP1Ciym9j/FIVJxYT YSOfwm5qFjr7BJJeJgZYqzchTFxSlwSLgtXKPXXrhKHk2PgG47XMcG91eecOB2Ip pkfsEjb0XEuIGMM1sCe8T4T8XsIGOI+TSAoPl0XbwPNlgcGilJGM6bFThZWKmTjG kdxdLuz+mCPwzWojeBPiPk0w8jD/1Irg88JQQ1zYmuXUJrtdWMyrKePtgEa+YdR6 0qI+6I1Yf6qzqZwxLPZgG7pAwQgcJcVgqYHkJf2xrzN3rf7LDjPORcuQYyPwX/RP fXQZ3VbG6cM= =T2vT -----END PGP SIGNATURE----- --Sig_/WNCQMIJbJYzQj77bz+/zabs-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/