Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757198AbbEFDIV (ORCPT ); Tue, 5 May 2015 23:08:21 -0400 Received: from mail-ie0-f181.google.com ([209.85.223.181]:33417 "EHLO mail-ie0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756965AbbEFDIR (ORCPT ); Tue, 5 May 2015 23:08:17 -0400 Message-ID: <5549859F.4020706@google.com> Date: Tue, 05 May 2015 20:08:15 -0700 From: Badhri Jagan Sridharan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Steven Rostedt CC: Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH] tracing: Adds handler name to irq_handler_entry References: <1430873218-3142-1-git-send-email-Badhri@google.com> <20150505214619.14a60669@grimm.local.home> In-Reply-To: <20150505214619.14a60669@grimm.local.home> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1541 Lines: 52 Done!! Uploaded a new patch v2. On 05/05/2015 06:46 PM, Steven Rostedt wrote: > On Tue, 5 May 2015 17:46:58 -0700 > Badhri Jagan Sridharan wrote: > >> This patch includes the ISR function name to >> irq_handler_entry trace point. >> >> Signed-off-by: Badhri Jagan Sridharan >> --- >> include/trace/events/irq.h | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/include/trace/events/irq.h b/include/trace/events/irq.h >> index ff8f6c0..9994ba4 100644 >> --- a/include/trace/events/irq.h >> +++ b/include/trace/events/irq.h >> @@ -58,14 +58,17 @@ TRACE_EVENT(irq_handler_entry, >> TP_STRUCT__entry( >> __field( int, irq ) >> __string( name, action->name ) >> + __field(void*, handler) > > Please follow the format that the other fields have. This isn't a > function call to use the "checkpatch" version of indentation. > > __field( void *, handler ) > > -- Steve > >> ), >> >> TP_fast_assign( >> __entry->irq = irq; >> __assign_str(name, action->name); >> + __entry->handler = action->handler; >> ), >> >> - TP_printk("irq=%d name=%s", __entry->irq, __get_str(name)) >> + TP_printk("irq=%d name=%s handler=%pf", >> + __entry->irq, __get_str(name), __entry->handler) >> ); >> >> /** > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/